[
https://issues.apache.org/jira/browse/CAMEL-19497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737518#comment-17737518
]
Otavio Rodolfo Piske edited comment on CAMEL-19497 at 6/27/23 8:17 AM:
-----------------------------------------------------------------------
More specifically: the condition that could lead to the code blocking is fixed.
We can just catch an AssertionError instead of Throwable (which is the right
thing to do - avoid trying to catch InternalErrors and other errors that must
not be caught).
However, the point of the issue is different: the point is that, in some
circumstances, the code could block indefinitely.
was (Author: orpiske):
It's fixed. We can just catch an AssertionError instead of Throwable (which is
the right thing to do - avoid trying to catch InternalErrors and other errors
that must not be caught), but the point of the issue is different. The point is
that, in some circumstances, the code could block.
> camel-core: DefaultAsyncProcessorAwaitManager can lock forever
> --------------------------------------------------------------
>
> Key: CAMEL-19497
> URL: https://issues.apache.org/jira/browse/CAMEL-19497
> Project: Camel
> Issue Type: Task
> Components: camel-core
> Reporter: Otavio Rodolfo Piske
> Priority: Major
>
> I am not sure if this is a bug or not, so this is more like an investigative
> task.
>
> The DefaultAsyncProcessorAwaitManager can [lock
> indefinitely|https://github.com/apache/camel/blob/b2f6af4a695439d51ace77331f79157547f6cfd8/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultAsyncProcessorAwaitManager.java#L105]
> under some circumstances.
>
> One scenario where this could happen is by ignoring/not handling the
> exceptions on [this block on the
> AbstractBeanProcessor|https://github.com/apache/camel/blob/main/components/camel-bean/src/main/java/org/apache/camel/component/bean/AbstractBeanProcessor.java#L109].
> This was originally found when fixing the code to not catch a Throwable and
> then running the BeanThrowAssertionErrorTest. Because that test would throw a
> descendant of an AssertionError, it would cause the code to not handle the
> exception.
> This [has been fixed already|https://github.com/apache/camel/pull/10489], but
> there could be other circumstances that could cause this.
>
> Maybe we should investigate if it's feasible to have a timeout or something
> similar.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
