[
https://issues.apache.org/jira/browse/CAMEL-18851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Claus Ibsen resolved CAMEL-18851.
---------------------------------
Resolution: Fixed
> minor findings of apache camel release 3.20.0
> ---------------------------------------------
>
> Key: CAMEL-18851
> URL: https://issues.apache.org/jira/browse/CAMEL-18851
> Project: Camel
> Issue Type: Task
> Components: build system
> Reporter: Claus Ibsen
> Priority: Minor
> Fix For: Future
>
>
> Christofer Dutz [email protected] via camel.apache.org
> Sun, Dec 18, 2022, 1:31 PM
> to [email protected]
> +1 (non-binding)
> Chris
> [OK] Download all staged artifacts under the url specified in the release
> vote email.
> [OK] Verify the signature is correct.
> A link to the Apache Camel KEYS file in the VOTE email would be great
> [OK] Check if the signature references an Apache email address.
> [MINOR] Verify the SHA512 hashes.
> SHA1 Hashes are considered deprecated and should be replaced by SHA512 hashes
> (https://www.apache.org/info/verification.html)
> [OK] Unzip the archive.
> [OK] Verify the existence of LICENSE, NOTICE, README files in the extracted
> source bundle.
> [OK] Verify the content of LICENSE, NOTICE, README files in the extracted
> source bundle.
> [MINOR] [RM] Run RAT externally to ensure there are no surprises.
> A lot of generated code and other properties and adoc files, which could
> contain Apache headers don’t seem to contain any (As most contain the remark
> that they are generated by the camel build tools, it should be quite simple
> to add the headers to them)
> Bundling jar content is only acceptable for test-resources (and should be
> avoided in general). gardle-wrapper.jar and maven-wrapper.jar don’t fit that
> category. I updated the Maven-wrapper some time to also work without the jar
> file, so perhaps updating to that would at least eliminate that jar.
> [OK] Search for SNAPSHOT references
> [MINOR] Search for Copyright references, and if they are in headers, make
> sure these files containing them are mentioned in the LICENSE file.
> Some LICENSE files refer to the ICU license and that this product would
> contain parts under that license; however I couldn’t find any code. Depending
> on this code might not require mentioning it this way?
> (apache-camel-3.20.0/components/camel-bindy)
> [MINOR] Build the project according to the information in the README.md file.
> The maven-wrapper script isn’t executable and needs to manually be made
> executable on mac (and probably Linux)
> Even if the root contains the maven-wrapper scripts, they can’t be used as
> none of the resources the maven-wrapper relies on are included in the zip
> The build is mostly successful if I build everything with disabled
> test-execution, however I get a failure pretty much at the end … in the
> “Camel :: Docs” with “'yarn gulp' failed”
> When building with “mvn clean install” in the root I’m getting build failures
> in camel-archetype-main and camel-archetype-spring (It seems the problem is
> related to me not having built camel before and the integration tests seem to
> require some libraries being built before the integration-test is run … in my
> case it was complaining about not finding camel-test-main-junit5. Maybe it’s
> a good idea to add the direct dependencies the integration-tests require as
> “provided” dependencies, so maven ensures they are built first.
> The parent pom doesn’t reference the latest apache parent, which is currently
> 29. It currently references version 25.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
