[
https://issues.apache.org/jira/browse/CAMEL-19635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Otavio Rodolfo Piske updated CAMEL-19635:
-----------------------------------------
Description:
AS2 tests are textbook example of how not to write a modern tests.
Things to fix:
* [Test
resources|https://github.com/apache/camel/blob/cb997651b579b60ff9a5e7eca36a70efa007c38c/components/camel-as2/camel-as2-component/src/test/java/org/apache/camel/component/as2/AS2ServerManagerIT.java#L227-L231]
and [their
management|https://github.com/apache/camel/blob/cb997651b579b60ff9a5e7eca36a70efa007c38c/components/camel-as2/camel-as2-component/src/test/java/org/apache/camel/component/as2/AS2ServerManagerIT.java#L232-L238]
are way too tightly coupled to the tests
*
[Assumptions|https://github.com/apache/camel/blob/cb997651b579b60ff9a5e7eca36a70efa007c38c/components/camel-as2/camel-as2-component/src/test/java/org/apache/camel/component/as2/AS2ServerManagerIT.java#L255]
are [handled as
assertions|https://github.com/apache/camel/blob/cb997651b579b60ff9a5e7eca36a70efa007c38c/components/camel-as2/camel-as2-component/src/test/java/org/apache/camel/component/as2/AS2ServerManagerIT.java#L276].
* Too much being tested in a [single
test|https://github.com/apache/camel/blob/cb997651b579b60ff9a5e7eca36a70efa007c38c/components/camel-as2/camel-as2-component/src/test/java/org/apache/camel/component/as2/AS2ServerManagerIT.java#L225]
and even more in a single class
* [Broken
logs|https://github.com/apache/camel/blob/cb997651b579b60ff9a5e7eca36a70efa007c38c/components/camel-as2/camel-as2-component/src/test/java/org/apache/camel/component/as2/AS2ServerManagerIT.java#L255].
* Not [handling
exceptions|https://github.com/apache/camel/blob/cb997651b579b60ff9a5e7eca36a70efa007c38c/components/camel-as2/camel-as2-component/src/test/java/org/apache/camel/component/as2/AS2ClientManagerIT.java#L326]
as an assertion when it [likely
should|https://github.com/apache/camel/blob/cb997651b579b60ff9a5e7eca36a70efa007c38c/components/camel-as2/camel-as2-component/src/test/java/org/apache/camel/component/as2/AS2ClientManagerIT.java#L354].
* Unused variables
was:
AS2 tests are textbook example of how not to write a modern tests.
Things to fix:
* [Test
resources|https://github.com/apache/camel/blob/cb997651b579b60ff9a5e7eca36a70efa007c38c/components/camel-as2/camel-as2-component/src/test/java/org/apache/camel/component/as2/AS2ServerManagerIT.java#L227-L231]
and [their
management|https://github.com/apache/camel/blob/cb997651b579b60ff9a5e7eca36a70efa007c38c/components/camel-as2/camel-as2-component/src/test/java/org/apache/camel/component/as2/AS2ServerManagerIT.java#L232-L238]
are way too tightly coupled to the tests
*
[Assumptions|https://github.com/apache/camel/blob/cb997651b579b60ff9a5e7eca36a70efa007c38c/components/camel-as2/camel-as2-component/src/test/java/org/apache/camel/component/as2/AS2ServerManagerIT.java#L255]
are [handled as
assertions|https://github.com/apache/camel/blob/cb997651b579b60ff9a5e7eca36a70efa007c38c/components/camel-as2/camel-as2-component/src/test/java/org/apache/camel/component/as2/AS2ServerManagerIT.java#L276].
* Too much being tested in a [single
test|https://github.com/apache/camel/blob/cb997651b579b60ff9a5e7eca36a70efa007c38c/components/camel-as2/camel-as2-component/src/test/java/org/apache/camel/component/as2/AS2ServerManagerIT.java#L255]
and even more in a single class
* [Broken
logs|https://github.com/apache/camel/blob/cb997651b579b60ff9a5e7eca36a70efa007c38c/components/camel-as2/camel-as2-component/src/test/java/org/apache/camel/component/as2/AS2ServerManagerIT.java#L255].
* Not [handling
exceptions|https://github.com/apache/camel/blob/cb997651b579b60ff9a5e7eca36a70efa007c38c/components/camel-as2/camel-as2-component/src/test/java/org/apache/camel/component/as2/AS2ClientManagerIT.java#L326]
as an assertion when it [likely
should|https://github.com/apache/camel/blob/cb997651b579b60ff9a5e7eca36a70efa007c38c/components/camel-as2/camel-as2-component/src/test/java/org/apache/camel/component/as2/AS2ClientManagerIT.java#L354].
* Unused variables
> camel-as2: cleanup the tests
> ----------------------------
>
> Key: CAMEL-19635
> URL: https://issues.apache.org/jira/browse/CAMEL-19635
> Project: Camel
> Issue Type: Test
> Components: camel-as2
> Reporter: Otavio Rodolfo Piske
> Priority: Major
> Labels: easy
>
> AS2 tests are textbook example of how not to write a modern tests.
> Things to fix:
> * [Test
> resources|https://github.com/apache/camel/blob/cb997651b579b60ff9a5e7eca36a70efa007c38c/components/camel-as2/camel-as2-component/src/test/java/org/apache/camel/component/as2/AS2ServerManagerIT.java#L227-L231]
> and [their
> management|https://github.com/apache/camel/blob/cb997651b579b60ff9a5e7eca36a70efa007c38c/components/camel-as2/camel-as2-component/src/test/java/org/apache/camel/component/as2/AS2ServerManagerIT.java#L232-L238]
> are way too tightly coupled to the tests
> *
> [Assumptions|https://github.com/apache/camel/blob/cb997651b579b60ff9a5e7eca36a70efa007c38c/components/camel-as2/camel-as2-component/src/test/java/org/apache/camel/component/as2/AS2ServerManagerIT.java#L255]
> are [handled as
> assertions|https://github.com/apache/camel/blob/cb997651b579b60ff9a5e7eca36a70efa007c38c/components/camel-as2/camel-as2-component/src/test/java/org/apache/camel/component/as2/AS2ServerManagerIT.java#L276].
> * Too much being tested in a [single
> test|https://github.com/apache/camel/blob/cb997651b579b60ff9a5e7eca36a70efa007c38c/components/camel-as2/camel-as2-component/src/test/java/org/apache/camel/component/as2/AS2ServerManagerIT.java#L225]
> and even more in a single class
> * [Broken
> logs|https://github.com/apache/camel/blob/cb997651b579b60ff9a5e7eca36a70efa007c38c/components/camel-as2/camel-as2-component/src/test/java/org/apache/camel/component/as2/AS2ServerManagerIT.java#L255].
> * Not [handling
> exceptions|https://github.com/apache/camel/blob/cb997651b579b60ff9a5e7eca36a70efa007c38c/components/camel-as2/camel-as2-component/src/test/java/org/apache/camel/component/as2/AS2ClientManagerIT.java#L326]
> as an assertion when it [likely
> should|https://github.com/apache/camel/blob/cb997651b579b60ff9a5e7eca36a70efa007c38c/components/camel-as2/camel-as2-component/src/test/java/org/apache/camel/component/as2/AS2ClientManagerIT.java#L354].
>
> * Unused variables
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
