[
https://issues.apache.org/jira/browse/CAMEL-20123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789214#comment-17789214
]
Otavio Rodolfo Piske edited comment on CAMEL-20123 at 11/23/23 4:56 PM:
------------------------------------------------------------------------
So, I would like to keep the containers image name in a separate file.
For instance, something like:
{{src/org/apache/came/<test-infra-specific-package/containers.properties}}
That file would contain:
{{elasticsearch=docker.elastic.co/elasticsearch/elasticsearch:8.11.1}}
Then, change the code to read the container information from that file:
{{ElasticsearchContainer elasticsearchContainer =
ContainerImageLoader.getImageNameFor(this.class, "elasticsearch");}}
Having this on a separate file, then I may be able to write a bash script to
check if there's a new container available or not (to be defined on a separate
ticket after this is done).
was (Author: orpiske):
So, I would like to keep the containers image name in a separate file.
For instance, something like:
{{src/org/apache/came/<test-infra-specific-package/containers.properties }}
That file would contain:
{{elasticsearch=docker.elastic.co/elasticsearch/elasticsearch:8.11.1}}
Then, change the code to read the container information from that file:
{{ElasticsearchContainer elasticsearchContainer =
ContainerImageLoader.getImageNameFor(this.class, "elasticsearch");}}
Having this on a separate file, then I may be able to write a bash script to
check if there's a new container available or not (to be defined on a separate
ticket after this is done).
> camel-test-infra: externalize container information
> ---------------------------------------------------
>
> Key: CAMEL-20123
> URL: https://issues.apache.org/jira/browse/CAMEL-20123
> Project: Camel
> Issue Type: Task
> Components: camel-test-infra
> Affects Versions: 4.3.0
> Reporter: Otavio Rodolfo Piske
> Priority: Major
> Labels: help-wanted
> Fix For: 4.x
>
>
> Currently, our test-infra code refers to containers in code. For instance:
> {code:java}
> public static final String DEFAULT_ELASTIC_SEARCH_CONTAINER =
> "docker.elastic.co/elasticsearch/elasticsearch:8.11.1";
> ...
> ElasticsearchContainer elasticsearchContainer = new
> ElasticsearchContainer(DEFAULT_ELASTIC_SEARCH_CONTAINER)
> {code}
> The challenge with this approach is that we have to verify file by file if
> there is an upgrade to the containers.
> Ideally, we should keep this information in a properties file named
> `containers.properties`. This could allow us to automate checking if there is
> an updated version of those containers and reduce the maintenance effort.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
