[
https://issues.apache.org/jira/browse/CAMEL-21257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884623#comment-17884623
]
Claus Ibsen commented on CAMEL-21257:
-------------------------------------
Yeah however it seems CAMEL-15998 changed it to that message. I guess it was
easier for prototyping / logging. However the actual RepositoryCommit is better
as you may need to know what files was in the commit and so on.
So I think the consumer should be changed to store the RepositoryCommit and we
can do that from 4.9 onwards. And just add a note in the upgrade guide.
> Camel GitHub commit consumer body does not match documentation
> --------------------------------------------------------------
>
> Key: CAMEL-21257
> URL: https://issues.apache.org/jira/browse/CAMEL-21257
> Project: Camel
> Issue Type: Task
> Components: camel-github
> Affects Versions: 4.8.0
> Reporter: Chris Slater
> Priority: Minor
>
> In the GitHub consumer documentation,
> [https://camel.apache.org/components/4.8.x/github-component.html#_consumer_endpoints,]
> the body type for the commit endpoint is listed as a
> org.eclipse.egit.github.core.RepositoryCommit. However, it is not. It is a
> String with the commit message.
> I'm not sure if this is a problem with the documentation or the code.
> Changing the body to a RepositoryCommit would be consistent with the other
> consumers. For example, the tag consumer does provide a body type of
> RepositoryTag. Additionally, more information would be available from a
> RepositoryCommit object compared to the commit message and a few headers with
> some of the other information.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
