[ 
https://issues.apache.org/jira/browse/CAMEL-21663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17921412#comment-17921412
 ] 

Otavio Rodolfo Piske commented on CAMEL-21663:
----------------------------------------------

Same thing with 
[getJMSRedelivered|https://github.com/apache/camel/blob/camel-4.8.3/components/camel-sjms/src/main/java/org/apache/camel/component/sjms/jms/JmsMessageHelper.java#L324].

> camel-sjms2: lack of null check causes NPE and affects performance
> ------------------------------------------------------------------
>
>                 Key: CAMEL-21663
>                 URL: https://issues.apache.org/jira/browse/CAMEL-21663
>             Project: Camel
>          Issue Type: Task
>          Components: camel-sjms, camel-sjms2
>    Affects Versions: 4.8.3, 4.9.0, 4.10.0
>            Reporter: Otavio Rodolfo Piske
>            Assignee: Otavio Rodolfo Piske
>            Priority: Major
>         Attachments: Screenshot 2025-01-27 at 14.27.48.png
>
>
> Lack of a null check 
> [here|https://github.com/apache/camel/blob/camel-4.8.3/components/camel-sjms/src/main/java/org/apache/camel/component/sjms/jms/JmsMessageHelper.java#L435],
>  makes the rather inexpressive "getJMSCorrelationID" quite slow as the JMS 
> client can return null, causing the string initialization to throw an NPE.
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to