[
https://issues.apache.org/jira/browse/CAMEL-23578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrea Cosentino resolved CAMEL-23578.
--------------------------------------
Resolution: Fixed
> camel-web3j - align Exchange header constant names with Camel naming
> convention
> -------------------------------------------------------------------------------
>
> Key: CAMEL-23578
> URL: https://issues.apache.org/jira/browse/CAMEL-23578
> Project: Camel
> Issue Type: Improvement
> Components: camel-web3j
> Reporter: Andrea Cosentino
> Assignee: Andrea Cosentino
> Priority: Major
> Fix For: 4.21.0
>
>
> The Web3j header constants in
> {{org.apache.camel.component.web3j.Web3jConstants}} use uppercase string
> values that do not follow the Camel naming convention. The most
> security-relevant ones drive blockchain dispatch and transaction parameters:
> * {{OPERATION = "OPERATION"}} - dispatch across ~80 RPC methods including
> {{eth_sendTransaction}} / {{eth_sign}}
> * {{FROM_ADDRESS = "FROM_ADDRESS"}} / {{TO_ADDRESS = "TO_ADDRESS"}} / {{VALUE
> = "VALUE"}}
> * {{SIGNED_TRANSACTION_DATA}}, {{SHA3_HASH_OF_DATA_TO_SIGN}}
> * Plus ~25 more RPC argument headers ({{GAS_PRICE}}, {{GAS_LIMIT}},
> {{NONCE}}, {{DATA}}, {{TOPICS}}, {{PRIVATE_FOR}}, {{PRIVATE_FROM}}, ...)
> Rename to {{CamelWeb3j<Name>}} across all constants.
> h3. Fix shape
> Rename the *string value* of each producer-read header constant to
> {{Camel<Component><Name>}}; keep the Java field name unchanged so routes that
> reference the constants symbolically continue to compile and run. Update
> tests that use the literal string values; regenerate component catalog JSON
> and docs; add an upgrade-guide entry in {{camel-4x-upgrade-guide-4_21.adoc}}
> (and matching 4_18 / 4_14 for backports where the component existed in those
> branches).
> h3. References
> * Tracker: CAMEL-23577
> * Precedent (rename pattern): CAMEL-23526 (camel-cxf)
> * Alternative pattern (HeaderFilterStrategy approach): CAMEL-23532
> (camel-vertx-websocket / camel-atmosphere-websocket / camel-iggy)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
