[
https://issues.apache.org/jira/browse/CAMEL-23877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Claus Ibsen closed CAMEL-23877.
-------------------------------
Resolution: Fixed
Fixed via https://github.com/apache/camel/pull/24661 (merged to main)
> camel-pinecone: tls option runtime default does not match its documented
> defaultValue
> -------------------------------------------------------------------------------------
>
> Key: CAMEL-23877
> URL: https://issues.apache.org/jira/browse/CAMEL-23877
> Project: Camel
> Issue Type: Bug
> Components: camel-pinecone
> Reporter: Andrea Cosentino
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 4.22.0
>
>
> h3. Background
> In {{PineconeVectorDbConfiguration}}, the {{tls}} option is annotated
> {{@UriParam(defaultValue = "true", label = "security")}}, and the generated
> {{pinecone.json}} catalog documents {{"defaultValue": true}}. However, the
> Java field has no initializer, so its actual runtime default is {{false}}
> ({{@UriParam(defaultValue=...)}} is documentation metadata and does not set
> the field value).
> {{PineconeVectorDbEndpoint}} only acts in the {{if (!tls)}} branch
> ({{builder.withTlsEnabled(false)}}), which indicates the code was written
> assuming {{true}} is the normal case. The net effect is that an endpoint
> configured with no explicit {{tls}} parameter connects with TLS disabled,
> contradicting the documented default and the surrounding code's own
> assumption.
> h3. Proposed change
> Initialize the field to match the documented default:
> {code:java}
> private boolean tls = true;
> {code}
> h3. Affected code
> *
> {{components/camel-ai/camel-pinecone/src/main/java/org/apache/camel/component/pinecone/PineconeVectorDbConfiguration.java}}
> (~line 63)
> *
> {{components/camel-ai/camel-pinecone/src/main/java/org/apache/camel/component/pinecone/PineconeVectorDbEndpoint.java}}
> (~lines 105-109)
> h3. Notes
> * Add a regression test asserting a default-built configuration yields
> {{withTlsEnabled(true)}}.
> * This is a behavioral default change for anyone implicitly relying on the
> current value, so it warrants an upgrade-guide note.
> * Worth a quick check of sibling vector-store components (camel-milvus,
> camel-qdrant, camel-weaviate) for the same documentation-vs-field mismatch.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
