[
https://issues.apache.org/jira/browse/CAMEL-24719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrea Cosentino updated CAMEL-24719:
-------------------------------------
Description: WeaviateVectorDbHeaders.VECTOR_FIELD_NAME (advertised as the
miscased "CamelweaviateVectorFieldName") is read by
WeaviateEmbeddingsDataTypeTransformer and threaded through its
create/update/query operations, but the value is never used: the embedding
vector is always set as the message body (embedding.vectorAsList()), never
keyed by a field name. Weaviate stores the object vector directly and has no
named-vector-field concept here, so unlike the Milvus transformer this
parameter is a copy-paste artifact. The weaviate producer never references the
header either. Remove the dead header constant (and its deprecated
WeaviateVectorDb duplicate), drop the unused local and the unused parameter
threaded through the three operation methods, regenerate metadata, and note the
header removal in the 4.23 upgrade guide. (was: The
WeaviateVectorDbHeaders.VECTOR_FIELD_NAME constant is declared as
"CamelweaviateVectorFieldName" (lowercase w), while every other camel-weaviate
header uses the CamelWeaviate prefix (capital W): CamelWeaviateAction,
CamelWeaviateTextFieldName, CamelWeaviateCollectionName, etc. Since CAMEL-24533
wired the vector field name into WeaviateEmbeddingsDataTypeTransformer (it now
reads this header), a user who sets the header by its convention-expected name
CamelWeaviateVectorFieldName is silently ignored and the transformer falls back
to the default field name "vector". Correct the header value to
CamelWeaviateVectorFieldName for consistency with the other headers, update the
deprecated WeaviateVectorDb duplicate, regenerate metadata, and note the header
rename in the 4.23 upgrade guide.)
Summary: camel-weaviate: remove the dead VECTOR_FIELD_NAME header
(was: camel-weaviate: VECTOR_FIELD_NAME header value has inconsistent casing
(CamelweaviateVectorFieldName))
> camel-weaviate: remove the dead VECTOR_FIELD_NAME header
> --------------------------------------------------------
>
> Key: CAMEL-24719
> URL: https://issues.apache.org/jira/browse/CAMEL-24719
> Project: Camel
> Issue Type: Bug
> Reporter: Andrea Cosentino
> Assignee: Andrea Cosentino
> Priority: Major
>
> WeaviateVectorDbHeaders.VECTOR_FIELD_NAME (advertised as the miscased
> "CamelweaviateVectorFieldName") is read by
> WeaviateEmbeddingsDataTypeTransformer and threaded through its
> create/update/query operations, but the value is never used: the embedding
> vector is always set as the message body (embedding.vectorAsList()), never
> keyed by a field name. Weaviate stores the object vector directly and has no
> named-vector-field concept here, so unlike the Milvus transformer this
> parameter is a copy-paste artifact. The weaviate producer never references
> the header either. Remove the dead header constant (and its deprecated
> WeaviateVectorDb duplicate), drop the unused local and the unused parameter
> threaded through the three operation methods, regenerate metadata, and note
> the header removal in the 4.23 upgrade guide.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
