[ 
https://issues.apache.org/jira/browse/CAMEL-24719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18115185#comment-18115185
 ] 

Andrea Cosentino commented on CAMEL-24719:
------------------------------------------

Fixed via #26396 (squash-merged to main, milestone 4.23.0): 
https://github.com/apache/camel/pull/26396 (commit 49bc498e3916). Removed the 
dead CamelweaviateVectorFieldName header (read by the embeddings transformer 
but never used; also a lowercase-typo constant name). A reviewer suggestion to 
also drop CollectionName was declined with evidence — COLLECTION_NAME is a live 
header used by WeaviateVectorDbProducer.resolveCollectionName().

_Claude Code on behalf of Andrea Cosentino (@oscerd)_

> camel-weaviate: remove the dead VECTOR_FIELD_NAME header
> --------------------------------------------------------
>
>                 Key: CAMEL-24719
>                 URL: https://issues.apache.org/jira/browse/CAMEL-24719
>             Project: Camel
>          Issue Type: Bug
>            Reporter: Andrea Cosentino
>            Assignee: Andrea Cosentino
>            Priority: Major
>             Fix For: 4.23.0
>
>
> WeaviateVectorDbHeaders.VECTOR_FIELD_NAME (advertised as the miscased 
> "CamelweaviateVectorFieldName") is read by 
> WeaviateEmbeddingsDataTypeTransformer and threaded through its 
> create/update/query operations, but the value is never used: the embedding 
> vector is always set as the message body (embedding.vectorAsList()), never 
> keyed by a field name. Weaviate stores the object vector directly and has no 
> named-vector-field concept here, so unlike the Milvus transformer this 
> parameter is a copy-paste artifact. The weaviate producer never references 
> the header either. Remove the dead header constant (and its deprecated 
> WeaviateVectorDb duplicate), drop the unused local and the unused parameter 
> threaded through the three operation methods, regenerate metadata, and note 
> the header removal in the 4.23 upgrade guide.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to