[
https://issues.apache.org/jira/browse/CAMEL-24755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on CAMEL-24755 started by Andrea Cosentino.
------------------------------------------------
> camel-sql-stored - align the resource schemes named in the CAMEL-24292
> upgrade-guide entry
> ------------------------------------------------------------------------------------------
>
> Key: CAMEL-24755
> URL: https://issues.apache.org/jira/browse/CAMEL-24755
> Project: Camel
> Issue Type: Task
> Reporter: Andrea Cosentino
> Assignee: Andrea Cosentino
> Priority: Minor
>
> h2. Problem
> The upgrade-guide entry added by CAMEL-24292 (PR #26268) names the resource
> schemes {{SqlHelper.resolveQuery}} handles in three places, and the three
> disagree:
> * "resolves {{file:}} / {{http:}} / {{classpath:}} resources"
> * "never as a {{file:}} / {{http:}} resource"
> * "{{file:}}, {{http:}}, {{https:}} or {{classpath:}}"
> The {{@UriParam}} description on
> {{SqlStoredEndpoint.allowTemplateFromHeader}} - and so the generated catalog
> JSON and the option tooltip - says a fourth thing, {{file:/http:}}.
> The complete list is the third one. On a security gate this matters more than
> usual: a reader deciding whether the gate covers their case can reasonably
> conclude from the shorter lists that {{classpath:}} and {{https:}} templates
> are still resolved from a header, which they are not.
> Raised by [~davsclaus] and by the review bot on PR #26268, both rounds. The
> code changes from that review landed; this wording item did not.
> h2. Also missing
> [~davsclaus] noted a behaviour delta for users who opt *back in* with
> {{allowTemplateFromHeader=true}} that the guide does not mention.
> {{SqlHelper.resolveQuery}} applied placeholder resolution only to a value
> that had a scheme, so a schemeless header template previously reached the
> database untouched; it now always goes through
> {{SqlHelper.resolvePlaceholders}}, which drops {{--}} comment lines and blank
> lines and re-joins the rest with newlines. Immaterial for the single-line
> call syntax a stored-procedure template normally uses, but a route passing a
> multi-line commented template through the header will see the comments
> stripped.
> h2. Scope
> Documentation only - the guide entry and one {{@UriParam}} description, plus
> the regenerated catalog. {{main}} only; no behaviour change.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
