[
https://issues.apache.org/jira/browse/CAMEL-6850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13791442#comment-13791442
]
Claus Ibsen commented on CAMEL-6850:
------------------------------------
Thanks for the patch.
One note thought. As you introduce a scheduled thread pool with a single thread
{code}
+ private ScheduledExecutorService scheduler =
Executors.newSingleThreadScheduledExecutor();
{code}
We should have a way of controlling its lifecycle so the thread pool is
terminated when you stop etc.
We have API from CamelContext where we encourage component developers to use,
as it allows thread naming and helps with lifecycle of thread pools.
See getExecutorServiceManager on camel context.
> Allow AWS SQS to not ack or even if it doesn't encounter an exception
> ---------------------------------------------------------------------
>
> Key: CAMEL-6850
> URL: https://issues.apache.org/jira/browse/CAMEL-6850
> Project: Camel
> Issue Type: Improvement
> Components: camel-aws
> Affects Versions: 2.12.1
> Reporter: Christian Posta
> Fix For: 2.12.2, 2.13.0
>
> Attachments: CAMEL-6850.patch
>
>
> Since SQS doesn't allow selectors it could be nice to use camel's filtering
> and ignore messages that don't fit through that filter. Right now
> DeleteMessage is sent back onCompletion. Proposed is to set a header of some
> other facility to let the onCompletion know that even though there wasn't a
> failure, still don't send back the ack/delete message. I'll work on a patch.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
