[
https://issues.apache.org/jira/browse/CAMEL-23599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18118265#comment-18118265
]
Claus Ibsen commented on CAMEL-23599:
-------------------------------------
PR https://github.com/apache/camel/pull/26756 by Brijesh Thakkar is a more
complete proposal than the old Dependabot bump in PR 23397: it also handles the
artifactId rename (swagger-request-validator-core ->
openapi-request-validator-core) and the changed validation message (3.0.0 swaps
com.github.java-json-tools for com.networknt:json-schema-validator, which is
already managed at 2.0.1 in parent/pom.xml, so no version conflict).
It was closed because the JDK 21 blocker is confirmed:
openapi-request-validator 3.0.0 sets maven.compiler.release=21 and the
published jar is class file major version 65. Camel is still on
<jdk.version>17</jdk.version>.
Worth noting for whoever picks this up: CI passes on this upgrade. javac on a
JDK 21 runner reads major-65 class files even with --release 17, so the build
stays green and the failure only appears as UnsupportedClassVersionError for
users running camel-openapi-validator on a Java 17 JRE.
When Camel drops Java 17, reopen PR 26756 (preferred over 23397). One fix
needed there: OpenApiRestClientRequestValidatorTest#testValidateBody dropped
Assertions.assertNotNull(error) along with the message assertion, which turns a
clean assertion failure into an NPE.
_Claude Code on behalf of davsclaus_
> [JDK 21] Upgrade com.atlassian.oai:swagger-request-validator-core from 2.x to
> com.atlassian.oai:openapi-request-validator-core 3.x
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-23599
> URL: https://issues.apache.org/jira/browse/CAMEL-23599
> Project: Camel
> Issue Type: Dependency upgrade
> Components: camel-openapi-validator
> Affects Versions: 4.20.0
> Reporter: Aurélien Pupier
> Priority: Major
>
> ir requires JDK
> 21https://github.com/atlassian/openapi-request-validator/commit/bbeb88baf7d9641e856bc5e5523a83c6c14a5a30
> the artifact id has been renamed for 3.0.0 (even if it exists with there
> old one) from com.atlassian.oai:swagger-request-validator-core from to
> com.atlassian.oai:openapi-request-validator-core
> an error message has slightly changed.
> see for an upgrade proposal
> https://github.com/apache/camel/pull/23397/changes/b1c9866207a33b8cad7a6520342fea916f287528
> PR to reopen when this issue is fixed
> https://github.com/apache/camel/pull/23397 (so that Dependabot will pick it
> up and be able to provide new PRs)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
