[ 
https://issues.apache.org/jira/browse/CAMEL-25939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18130579#comment-18130579
 ] 

Claus Ibsen commented on CAMEL-25939:
-------------------------------------

Merged to main via https://github.com/apache/camel/pull/28254 (commit 
1975e38a2ccc).

> camel-milo - the retry of refused monitored items follows reconnectTimeout in 
> its docs and tests
> ------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-25939
>                 URL: https://issues.apache.org/jira/browse/CAMEL-25939
>             Project: Camel
>          Issue Type: Task
>          Components: camel-milo
>            Reporter: Serdar Gökay
>            Assignee: Serdar Gökay
>            Priority: Minor
>             Fix For: 4.24.0
>
>
> Since CAMEL-25692 and CAMEL-25873 (both 4.24.0), a monitored item that the 
> server refused is created again every {{reconnectTimeout}} milliseconds 
> (default 10 000), the delay that also separates two connection attempts. The 
> WARN of the refusal already logs that interval. Three texts still describe a 
> fixed 10 seconds, or only the connection attempts:
> * the milo-client component page ("tries to create its monitored item again 
> every 10 seconds");
> * the 4.24 upgrade note of CAMEL-25692 ("created again every 10 seconds");
> * the description of the {{reconnectTimeout}} option, which names only the 
> connection attempts.
> {{MonitoredItemRetryTest}} and {{CommunicationLossTest}} use the default 
> interval, so their waits are sized for it, for example quiet periods of 12 
> and 15 seconds, and the module's tests take longer than they need.
> Change: name {{reconnectTimeout}} in the three texts, and set a short 
> {{reconnectTimeout}} in the retry tests with matching shorter waits. This is 
> the follow-up agreed in the review of [PR 
> 28212|https://github.com/apache/camel/pull/28212]. I can provide the pull 
> request.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to