Babak Vahdat created CAMEL-6951:
-----------------------------------
Summary: camel-core - Improve ServiceHelper utility class.
Key: CAMEL-6951
URL: https://issues.apache.org/jira/browse/CAMEL-6951
Project: Camel
Issue Type: Improvement
Components: camel-core
Affects Versions: 2.12.1
Reporter: Babak Vahdat
Assignee: Babak Vahdat
Priority: Minor
Fix For: 2.11.3, 2.12.2, 2.13.0
There're bunch of minor flaws by the {{ServiceHelper}} utility class such as:
- The {{stopAndShutdownServices(Collection<?> services)}} method has a minor
bug in that it does *not* stop each given service inside the {{try/catch}}
block. Potentially this would cause us to *miss* stopping/shutting down the
remaining elements of the given {{services}} in case stopping of one the
service objects would throw an exception!
- There's the missing utility method with the following signature:
{code}
public static void stopService(Service service) throws Exception;
{code}
- Lack of Javadoc by bunch of it's utility methods.
- Some existing Javadoc is not really clear & precise about what the method
exactly/really does.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
