Claus Ibsen created CAMEL-26217:
-----------------------------------
Summary: camel-tensorflow-serving - a body that is not the request
type is dropped silently and an empty request is sent
Key: CAMEL-26217
URL: https://issues.apache.org/jira/browse/CAMEL-26217
Project: Camel
Issue Type: Bug
Components: camel-ai
Reporter: Claus Ibsen
Fix For: 4.24.0
Found while adding the catalog body types of tensorflow-serving (CAMEL-24961,
PR #28402).
h4. 1. A body that is not the request type is dropped silently
{{TensorFlowServingProducer}} (main 2a465aa4814c, lines 97, 108, 120, 131 and
142) reads the body with {{getBody(<Request>.class)}} and merges it only when
not null; any other body (text, bytes, a Map) is dropped and an empty request
is sent, so predict fails on the server with "Missing but required: \{x\}" with
no hint about the body. Checked on 4.24.0-SNAPSHOT with an in-process gRPC fake
and the bitnamilegacy/tensorflow-serving 2.19.1 image (half_plus_two).
Proposed: fail with a message that names the expected request type when the
body is not null and cannot be converted.
h4. 2. model-metadata adds signature_def twice
{{modelMetadata}} (lines 109-113) adds the {{signature_def}} metadata field and
then {{mergeFrom(request)}}; when the request already has it, the repeated
field holds it twice. Read in the code, not run.
Proposed: add {{signature_def}} only when the request has no metadata field.
_Claude Code on behalf of davsclaus_
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
