[
https://issues.apache.org/jira/browse/CAMEL-26274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Claus Ibsen updated CAMEL-26274:
--------------------------------
Description:
Found while adding the catalog body types of docker (CAMEL-24961, PR #28414).
{{DockerClientFactory}} (main 2a465aa4814c, lines 50-79) takes the host, the
port, the socket, the username, the password and the server address of the
registry from the {{CamelDocker*}} headers when they are set, before the
endpoint configuration ({{DockerHelper.getProperty}}). A message can so point
the client at another Docker daemon, or send the registry username and password
configured on the endpoint to another registry host.
The same applies to four more settings that {{DockerClientFactory}} (lines
75-83) reads the same way: {{CamelDockerSecure}} ({{secure}}),
{{CamelDockerTlsVerify}} ({{tlsVerify}}), {{CamelDockerCertPath}}
({{certPath}}) and {{CamelDockerCmdExecFactory}} ({{cmdExecFactory}}, the class
name of the {{DockerCmdExecFactory}} to create). A message can so turn TLS to
the daemon on or off, or pick other client certificates. All of them are part
of the client profile, so a different value also creates and caches another
Docker client.
Proposed: take these connection and credential settings from the endpoint only,
and from headers only with a new endpoint option (default false), with an entry
in the upgrade guide. The operation headers can stay as they are.
_Claude Code on behalf of davsclaus_
was:
Found while adding the catalog body types of docker (CAMEL-24961, PR #28414).
{{DockerClientFactory}} (main 2a465aa4814c, lines 50-79) takes the host, the
port, the socket, the username, the password and the server address of the
registry from the {{CamelDocker*}} headers when they are set, before the
endpoint configuration ({{DockerHelper.getProperty}}). A message can so point
the client at another Docker daemon, or send the registry username and password
configured on the endpoint to another registry host.
Proposed: take these connection and credential settings from the endpoint only,
and from headers only with a new endpoint option (default false), with an entry
in the upgrade guide. The operation headers can stay as they are.
_Claude Code on behalf of davsclaus_
> camel-docker - the connection and registry credential settings should not be
> taken from message headers by default
> ------------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-26274
> URL: https://issues.apache.org/jira/browse/CAMEL-26274
> Project: Camel
> Issue Type: Improvement
> Components: camel-docker
> Reporter: Claus Ibsen
> Priority: Minor
> Fix For: 4.24.0
>
>
> Found while adding the catalog body types of docker (CAMEL-24961, PR #28414).
> {{DockerClientFactory}} (main 2a465aa4814c, lines 50-79) takes the host, the
> port, the socket, the username, the password and the server address of the
> registry from the {{CamelDocker*}} headers when they are set, before the
> endpoint configuration ({{DockerHelper.getProperty}}). A message can so point
> the client at another Docker daemon, or send the registry username and
> password configured on the endpoint to another registry host.
> The same applies to four more settings that {{DockerClientFactory}} (lines
> 75-83) reads the same way: {{CamelDockerSecure}} ({{secure}}),
> {{CamelDockerTlsVerify}} ({{tlsVerify}}), {{CamelDockerCertPath}}
> ({{certPath}}) and {{CamelDockerCmdExecFactory}} ({{cmdExecFactory}}, the
> class name of the {{DockerCmdExecFactory}} to create). A message can so turn
> TLS to the daemon on or off, or pick other client certificates. All of them
> are part of the client profile, so a different value also creates and caches
> another Docker client.
> Proposed: take these connection and credential settings from the endpoint
> only, and from headers only with a new endpoint option (default false), with
> an entry in the upgrade guide. The operation headers can stay as they are.
> _Claude Code on behalf of davsclaus_
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
