[
https://issues.apache.org/jira/browse/CAMEL-26514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18143070#comment-18143070
]
Urmila Unni commented on CAMEL-26514:
-------------------------------------
Hi, I'd like to work on this one. I'll follow the recommended option
(embed(EmbeddingRequest)) and send a PR with a test.
> camel-langchain4j-embeddings - the CamelLangChain4jEmbeddingsResponseModel
> header is never set
> ----------------------------------------------------------------------------------------------
>
> Key: CAMEL-26514
> URL: https://issues.apache.org/jira/browse/CAMEL-26514
> Project: Camel
> Issue Type: Improvement
> Components: camel-langchain4j-embeddings
> Reporter: Claus Ibsen
> Priority: Minor
> Fix For: 4.24.0
>
>
> Found while fixing CAMEL-26205. The producer calls the
> {{EmbeddingModel.embed(TextSegment)}} / {{embedAll(List)}} API, whose
> {{Response}} does not carry the model name, so the documented response model
> header is never set (and the GenAI usage has no response model).
> Options:
> * switch the producer to {{embed(EmbeddingRequest)}}, whose
> {{EmbeddingResponse.modelName()}} gives the model. Note: a model or test mock
> that only overrides {{embed(TextSegment)}} is then bypassed, and
> {{EmbeddingResponse}} has no finish reason;
> * or deprecate the header.
> Recommendation: the first option.
> _Claude Code on behalf of Claus Ibsen (davsclaus)_
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
