Andrea Cosentino created CAMEL-27024:
----------------------------------------

             Summary: camel-spring-boot: the early resolution of AWS Secrets 
Manager and Google Secret Manager properties never closes its client
                 Key: CAMEL-27024
                 URL: https://issues.apache.org/jira/browse/CAMEL-27024
             Project: Camel
          Issue Type: Improvement
          Components: camel-spring-boot-starters
            Reporter: Andrea Cosentino


The early resolution of vault properties of Camel on Spring Boot 
({{camel.component.<vault>.early-resolve-properties=true}}) creates a client in 
{{createPropertiesFunction}}, and nothing closes it once the properties are 
resolved:

* {{SpringBootAwsSecretsManagerPropertiesParser}}: a {{SecretsManagerClient}}, 
with its HTTP connection pool.
* {{SpringBootGoogleSecretManagerPropertiesParser}}: a 
{{SecretManagerServiceClient}}, with its gRPC channel and threads.

Both stay open for the life of the application, although the early resolution 
uses them only at startup.

CAMEL-26919 adds a {{release(PropertiesFunction)}} hook to 
{{AbstractEarlyResolutionPropertiesParser}} (apache/camel-spring-boot#2091). 
The base class calls it once the properties are resolved, also when they could 
not be, and logs and ignores a failure to release. Only the HashiCorp Vault 
parser overrides it so far. The AWS and GCP parsers could close their clients 
there too. The other parsers (Azure Key Vault, CyberArk, IBM Secrets Manager, 
Spring Cloud Config) should be checked for the same.

Suggested by [~fmariani] in the review of apache/camel-spring-boot#2091.

_Claude Code on behalf of oscerd_



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to