Saravanakumar Selvaraj created CAMEL-27138:
----------------------------------------------

             Summary: camel-alibaba-sls: the headers 
CamelAlibabaSlsLogStoreName and CamelAlibabaSlsLogstoreName are one header by 
default
                 Key: CAMEL-27138
                 URL: https://issues.apache.org/jira/browse/CAMEL-27138
             Project: Camel
          Issue Type: Bug
    Affects Versions: 4.23.0
            Reporter: Saravanakumar Selvaraj


Found while reviewing the descriptions of camel-alibaba-sls for CAMEL-23832.

The component has two headers whose names differ only in the case of one letter:

- CamelAlibabaSlsLogStoreName (AlibabaSlsHeaders.LOG_STORE_NAME) is the name of 
the Logstore for putLogs and getLogs. It replaces the logStoreName option.
- CamelAlibabaSlsLogstoreName (AlibabaSlsHeaders.LOGSTORE_NAME) is the name 
that listLogStores matches. Simple Log Service returns the Logstores whose name 
contains the value.

The headers of a Camel message are case-insensitive by default, as 
DefaultHeadersMapFactory uses a CaseInsensitiveMap. So by default the two names 
are one header. AlibabaSlsUtils.createClientConfigurations reads both names for 
each exchange, and both lookups find the same value.

What a route gets:

- A header set for putLogs or getLogs also limits a later listLogStores to the 
Logstores whose name contains the value.
- A header set for listLogStores also replaces the logStoreName option of a 
later putLogs or getLogs.

Exchange properties of these names stay apart, because the names of exchange 
properties are case-sensitive.

Proposed change: rename the header of listLogStores, for example to 
CamelAlibabaSlsListLogstoreName. The component already has 
CamelAlibabaSlsListOffset beside CamelAlibabaSlsOffset. The component was first 
released in 4.23.0, so the upgrade guide needs an entry.

_Claude Code on behalf of saravanakumar1987_



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to