[
https://issues.apache.org/jira/browse/CAMEL-7225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982285#comment-13982285
]
Daniel Pocock commented on CAMEL-7225:
--------------------------------------
I would regard this as a bug - ignoring the CHARSET_NAME header is just bad.
If CHARSET_NAME is not supported for now, then maybe the module should throw an
exception if it is present rather than silently ignoring it.
In any case, the fix doesn't appear to be hard. One of my GSoC applicants made
the fix as his coding test:
https://github.com/Radsaggi/camel/compare/issue-7225
Could somebody please review it and decide if it can be accepted?
One small enhancement to his patch: in the catch block for
UnsupportedEncodingException, it should log a warning or error and maybe it
should also log a debug level message about which encoding it is really using.
> camel-smpp - should check Exchange.CHARSET_NAME header
> ------------------------------------------------------
>
> Key: CAMEL-7225
> URL: https://issues.apache.org/jira/browse/CAMEL-7225
> Project: Camel
> Issue Type: Improvement
> Components: camel-smpp
> Affects Versions: 2.12.2
> Environment: any
> Reporter: Daniel Pocock
> Priority: Minor
> Fix For: Future
>
>
> The camel-smpp component should check the Exchange.CHARSET_NAME header of
> each message to determine the actual encoding of byte[] messages
> It appears that it currently expects all byte[] messages to be encoded in the
> character set specified by the "encoding" property on the endpoint
--
This message was sent by Atlassian JIRA
(v6.2#6252)
