[ 
https://issues.apache.org/jira/browse/CAMEL-7421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14021731#comment-14021731
 ] 

ASF GitHub Bot commented on CAMEL-7421:
---------------------------------------

GitHub user gquintana opened a pull request:

    https://github.com/apache/camel/pull/173

    CAMEL-7421 Producer Channel pooling

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gquintana/camel 
camel-7421-producer-channel-pooling

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/173.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #173
    
----
commit 974a8e803fe6c2bbab9c9a4ebb1247f9737196c1
Author: Gerald Quintana <[email protected]>
Date:   2014-05-14T14:35:21Z

    Adding Channel pooling in RabbitMQProducer

commit 752a3d2a64bbd76776dcacb0e57251bb7e6029f6
Author: Gerald Quintana <[email protected]>
Date:   2014-06-09T07:51:48Z

    Merge branch 'master' into camel-7421-producer-channel-pooling
    
    Conflicts:
        
components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitMQProducer.java

----


> camel-rabbitmq - Channel is not fully thread safe
> -------------------------------------------------
>
>                 Key: CAMEL-7421
>                 URL: https://issues.apache.org/jira/browse/CAMEL-7421
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-rabbitmq
>    Affects Versions: 2.12.3
>            Reporter: Gérald Quintana
>             Fix For: Future
>
>
> Channels are not fully thread-safe (see below), as a result the 
> RabbitMQProducer shouldn't use a single Channel. In short, Channels should be 
> pooled, and each thread given a Channel from the pool.
> http://www.rabbitmq.com/api-guide.html#channel-threads 
> {quote}applications should prefer using a Channel per thread instead of 
> sharing the same Channel across multiple threads.{quote}
> http://www.rabbitmq.com/javadoc/com/rabbitmq/client/Channel.html 
> {quote}An important caveat to this is that confirms are not handled properly 
> when a Channel is shared between multiple threads. In that scenario, it is 
> therefore important to ensure that the Channel instance is not accessed 
> concurrently by multiple threads.{quote}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to