[
https://issues.apache.org/jira/browse/CAMEL-7500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14032091#comment-14032091
]
Willem Jiang commented on CAMEL-7500:
-------------------------------------
In ClientChannelHandler, we need to updated the state of exceptionHandled to
avoid the callback be called twice when the ChannelClosedException is thrown. I
just committed a quick fix for that.
The other part of the issue is cased by Exchange instance could be modified by
more then one thread in you test case. Current RedeliveryErrorHandler doesn't
prevent this situation. It just treat the error handle is working in an single
thread environment.
Maybe we need to do some refactoring there.
> Concurrent modification of exchange during retry after netty TCP failure
> leads to futher processing of failed messages
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-7500
> URL: https://issues.apache.org/jira/browse/CAMEL-7500
> Project: Camel
> Issue Type: Bug
> Components: camel-netty
> Affects Versions: 2.13.1
> Reporter: Bob Browning
> Assignee: Willem Jiang
> Attachments: NettyRedeliveryTest.java
>
>
> When a exception occurs on a netty TCP channel such as ChanelClosedException
> then there are two invocations of the producer callback.
> If there is a redelivery handler configured this causes either two threads to
> be added to the scheduled thread-pool which then compete or in the more
> common case the first invocation adds the redelivery thread but in doing so
> clears the exception from the exchange such that when the subsequent callback
> invocation occurs it see's the event as a success and continues routing of
> the exchange.
> Note this also seems to be a cause of negative inflight messages on the route.
> The first callback invocation occurs in the ChannelFutureListener which is
> the usual case.
> The second callback invocation which comes from the ClientChannelHandler
> registered in the DefaultClientPipelineFactory used by the NettyProducer.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
