[ 
https://issues.apache.org/jira/browse/CAMEL-7855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14150585#comment-14150585
 ] 

Robert Elliot commented on CAMEL-7855:
--------------------------------------

Understood and thanks - my view would be that if that if the path
* route auto start = false
* call suspend first
* call resume
is illegal then an exception should be thrown to enforce the invariant.

I'm a bit concerned that the fix is purely aimed at the JMS component. 
ServiceSupport still allows a SuspendableService to go from Stopped -> 
suspend() -> Suspended -> resume() -> Started without ever calling doStart(), 
which means the logic "if never started, initialise" has to be done in every 
subclass of ServiceSupport - so any knew component may have the same bug.

> If you suspend a JMS route that is stopped, calling resume on it does not 
> work and reports no error
> ---------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-7855
>                 URL: https://issues.apache.org/jira/browse/CAMEL-7855
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-jms
>    Affects Versions: 2.14.0
>         Environment: All
>            Reporter: Robert Elliot
>            Assignee: Claus Ibsen
>            Priority: Minor
>             Fix For: 2.12.5, 2.13.3, 2.14.1, 2.15.0
>
>         Attachments: RouteLifecycleTest.java, pom.xml
>
>
> If a route that consumes from JMS is in state Stopped, and first Suspend and 
> then Resume are called upon it, the route reports itself as being in state 
> Started. However, it is not actually consuming anything from the endpoint.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to