[
https://issues.apache.org/jira/browse/CAMEL-8002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14200354#comment-14200354
]
ASF GitHub Bot commented on CAMEL-8002:
---------------------------------------
GitHub user dpocock opened a pull request:
https://github.com/apache/camel/pull/317
(work in progress) fix for CAMEL-8002, support for Latin1 coded SMS over
SMPP
Please discuss through the Jira issue:
https://issues.apache.org/jira/browse/CAMEL-8002
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dpocock/camel dpocock-smpp
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/317.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #317
----
commit 1c4e4e9aa0f59af6136b1cd7fa4eee7da38eacdc
Author: Daniel Pocock <[email protected]>
Date: 2014-11-05T15:49:58Z
Use UCS2 encoding if UCS2 alphabet specified
commit be729adb020ff9bc2c660ea6a916a68cd503a7b9
Author: Daniel Pocock <[email protected]>
Date: 2014-11-05T16:56:35Z
SmppUtils.isGsm0338Encodeable() expects Latin1 input, only use it if
encoding is Latin1 or ASCII
commit b0fa26afe21718a39c759ba13b0309da9034e3c6
Author: Daniel Pocock <[email protected]>
Date: 2014-11-06T15:50:12Z
Begin fixing CAMEL-8002, depends on pull req. 39 in jsmpp
----
> determineAlphabet only considers GSM 3.38 or UCS2
> -------------------------------------------------
>
> Key: CAMEL-8002
> URL: https://issues.apache.org/jira/browse/CAMEL-8002
> Project: Camel
> Issue Type: Bug
> Components: camel-smpp
> Affects Versions: 2.12.2
> Environment: n/a
> Reporter: Daniel Pocock
>
> SmppSmCommand.determineAlphabet(Message) tries to work out which SMPP
> alphabet code is suitable for encoding the message text.
> It checks if GSM 3.38 can represent all the characters in the message and if
> not it just uses UCS2 (UTF-16).
> This is less than optimal. Many messages using European languages can not be
> encoded in GSM 3.38 but they can be coded in Latin1, which is also supported
> by SMPP (data_coding / alphabet numeric code for Latin1 is 3)
> The jSMPP library (Alphabet.java) does not currently know about the alphabet
> code 3.
> I proposed a patch for jSMPP and if it is accepted then camel-smpp should be
> updated to use it. I already started writing a patch against camel-smpp.
> Here is the jSMPP patch:
> https://github.com/uudashr/jsmpp/pull/39
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
