[
https://issues.apache.org/jira/browse/CAMEL-8001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223233#comment-14223233
]
ASF GitHub Bot commented on CAMEL-8001:
---------------------------------------
GitHub user dpocock opened a pull request:
https://github.com/apache/camel/pull/339
Dpocock bug 8001
See https://issues.apache.org/jira/browse/CAMEL-8001
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dpocock/camel dpocock-bug-8001
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/339.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #339
----
commit c72c327cad45e79416ef5f524eba0bb4c95f07f2
Author: Daniel Pocock <[email protected]>
Date: 2014-11-24T18:11:31Z
CAMEL-8001: Add javadoc comments about the expectation that the argument is
ISO-8859-1 encoded
commit 1945bde0e522b50da626bf9d1650bedee074f1d9
Author: Daniel Pocock <[email protected]>
Date: 2014-11-24T18:12:34Z
CAMEL-8001: only try to use SmppUtils.isGsm0338Encodeable for content that
can already be ISO-8859-1 encoded
----
> SmppUtils.isGsm0338Encodeable() called with arbitrary data
> ----------------------------------------------------------
>
> Key: CAMEL-8001
> URL: https://issues.apache.org/jira/browse/CAMEL-8001
> Project: Camel
> Issue Type: Bug
> Components: camel-smpp
> Affects Versions: 2.12.2
> Environment: n/a
> Reporter: Daniel Pocock
> Labels: patch
> Attachments: determineAlphabet_fix.patch
>
>
> The method SmppUtils.isGsm0338Encodeable(byte[]) expects the input data to be
> Latin1 encoded (or a subset of Latin1, such as ASCII)
> The method SmppSmCommand.determineAlphabet(Message) prepares an argument by
> calling String.getBytes(charset) without checking the charset is Latin1 or
> compatible.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
