[ 
https://issues.apache.org/jira/browse/CAMEL-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321864#comment-14321864
 ] 

Claus Ibsen commented on CAMEL-8345:
------------------------------------

Willem you recent change is wrong.

A good idea when working on the model in camel-core, is to built it, then built 
camel-spring and check the camel-spring.xsd file to see what it looks like.

We would need to use a wrapper (or some other way of the JAXB annotations) or 
introduce a ConsumerPropertiesDefinition, and so on classes, that represent the 
List<PropertyDefinition> so the jaxb model is generated as my last example 
above.



> We should use Properties instead of Property to define the properties in 
> restConfiguration
> ------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-8345
>                 URL: https://issues.apache.org/jira/browse/CAMEL-8345
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.14.1
>            Reporter: Willem Jiang
>            Assignee: Willem Jiang
>             Fix For: 2.15.0
>
>
> Current <restConfiguration> use xxxProperty to specify the properties, it is 
> not the common usage. It could be better if we can fix it in Camel 2.15.0.
> {code}
>     @XmlElement(name = "componentProperty")
>     private List<RestPropertyDefinition> componentProperties = new 
> ArrayList<RestPropertyDefinition>();
>     @XmlElement(name = "endpointProperty")
>     private List<RestPropertyDefinition> endpointProperties = new 
> ArrayList<RestPropertyDefinition>();
>     @XmlElement(name = "consumerProperty")
>     private List<RestPropertyDefinition> consumerProperties = new 
> ArrayList<RestPropertyDefinition>();
>     @XmlElement(name = "dataFormatProperty")
>     private List<RestPropertyDefinition> dataFormatProperties = new 
> ArrayList<RestPropertyDefinition>();
> {code}
> The XmlElement need to be changed to 
> {code}
>     @XmlElement(name = "componentProperties")
>     private List<RestPropertyDefinition> componentProperties = new 
> ArrayList<RestPropertyDefinition>();
>     @XmlElement(name = "endpointProperties")
>     private List<RestPropertyDefinition> endpointProperties = new 
> ArrayList<RestPropertyDefinition>();
>     @XmlElement(name = "consumerProperties")
>     private List<RestPropertyDefinition> consumerProperties = new 
> ArrayList<RestPropertyDefinition>();
>     @XmlElement(name = "dataFormatProperties")
>     private List<RestPropertyDefinition> dataFormatProperties = new 
> ArrayList<RestPropertyDefinition>();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to