[
https://issues.apache.org/jira/browse/CAMEL-8366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14324463#comment-14324463
]
ASF GitHub Bot commented on CAMEL-8366:
---------------------------------------
GitHub user igarashitm opened a pull request:
https://github.com/apache/camel/pull/396
CAMEL-8366 Close used iterator if RuntimeException is thrown at next()/h...
...asNext() in Splitter
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/igarashitm/camel CAMEL-8366
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/396.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #396
----
commit 7e7574278fdffbf2b46a6b74397f6475fc812a7b
Author: Tomohisa Igarashi <[email protected]>
Date: 2015-02-17T16:41:00Z
CAMEL-8366 Close used iterator if RuntimeException is thrown at
next()/hasNext() in Splitter
----
> Close used iterator if RuntimeException is thrown at next()/hasNext() in
> Splitter/MulticastProcessor
> ----------------------------------------------------------------------------------------------------
>
> Key: CAMEL-8366
> URL: https://issues.apache.org/jira/browse/CAMEL-8366
> Project: Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Tomohisa Igarashi
>
> There're some spots using user provided iterator but don't close them if
> RuntimeException is thrown during iteration even if it's Closeable . It would
> be convenient if it is closed in finally block.
> I immediately found 2, guessing there're some more else:
> https://github.com/apache/camel/blob/master/camel-core/src/main/java/org/apache/camel/processor/Splitter.java#L232-L234
> https://github.com/apache/camel/blob/master/camel-core/src/main/java/org/apache/camel/processor/MulticastProcessor.java#L267-L347
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
