[ 
https://issues.apache.org/jira/browse/CAMEL-8394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14336607#comment-14336607
 ] 

ASF GitHub Bot commented on CAMEL-8394:
---------------------------------------

GitHub user sabre1041 opened a pull request:

    https://github.com/apache/camel/pull/409

    CAMEL-8394 Consolidated configurations and moved client state to component

    Consolidated user configurations by removing DockerClientProfile from 
DockerConfiguration class. Removed map of clients from configuration class to 
component

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sabre1041/camel CAMEL-8394

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/409.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #409
    
----
commit 987c8c15ca8cd29381dfa9dfc57814e693740b01
Author: Andrew Block <[email protected]>
Date:   2015-02-25T15:18:12Z

    CAMEL-8394 Consolidated configurations and moved client state to component

----


> camel-docker - DockerConfiguration should not keep client state
> ---------------------------------------------------------------
>
>                 Key: CAMEL-8394
>                 URL: https://issues.apache.org/jira/browse/CAMEL-8394
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-docker
>    Affects Versions: 2.15.0
>            Reporter: Claus Ibsen
>             Fix For: Future
>
>
> The configuration classes should be pure configuration, eg for users to 
> configure options.
> Any state such as client in use et all should be stored on endpoint or 
> component.
> eg move the options from DockerClientProfile to DockerConfiguration so there 
> is only 1 class.
> And move the map with DockerClient to the component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to