[ 
https://issues.apache.org/jira/browse/CAMEL-8452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14353734#comment-14353734
 ] 

ASF GitHub Bot commented on CAMEL-8452:
---------------------------------------

GitHub user chirino opened a pull request:

    https://github.com/apache/camel/pull/430

    Fix for CAMEL-8452: Camel route model - Preserve {{ }} placeholders 

    We preserve just the uri property of ProcessorDefinitions before we create 
the associated Processor and restore the original value after the the processor 
is created.
    
    We can probably target more properties to be preserved/restored as the need 
arrises.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chirino/camel CAMEL-8452

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/430.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #430
    
----
commit 87d8893b701247981a69d0fe32d3be06cf2edc7e
Author: Hiram Chirino <[email protected]>
Date:   2015-03-09T21:53:38Z

    Fix for CAMEL-8452: Camel route model - Preserve {{ }} placeholders in model
    
    We preserve just the uri property of ProcessorDefinitions before we create 
the associated Processor and restore the original value after the the processor 
is created.
    
    We can probably target more properties to be preserved/restored as the need 
arrises.

----


> Camel route model - Preserve {{ }} placeholders in model
> --------------------------------------------------------
>
>                 Key: CAMEL-8452
>                 URL: https://issues.apache.org/jira/browse/CAMEL-8452
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.15.0
>            Reporter: Claus Ibsen
>             Fix For: 2.16.0
>
>
> When people use {{ }} property placeholders in the route model, it gets 
> resolved with the actual value during route creation, and the original {{ }} 
> is lost.
> What we should do is preserve the {{ }} and do the resolve on demand (on 
> access). The trick is to make this transparent, or to keep a shadow map of 
> the {{ }} to actual mapping or something.
> But by preserving the {{ }} we can make round trip editing possible. And also 
> if people use {{ }} for username and passwords, then they are not exposed in 
> the model.
> ITs this logic that resolves the placeholders currently
> org.apache.camel.model.ProcessorDefinitionHelper#resolvePropertyPlaceholders(org.apache.camel.CamelContext,
>  java.lang.Object)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to