[
https://issues.apache.org/jira/browse/CAMEL-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525209#comment-14525209
]
ASF GitHub Bot commented on CAMEL-8640:
---------------------------------------
GitHub user rbudzko opened a pull request:
https://github.com/apache/camel/pull/508
CAMEL-8640 on Camel 2.15.x
Encapsulated BacklogTracer queue.
Implementation of queue changed to list based instead of array based.
Ensuring free space in queue responsibility moved into BacklogTracer
instead from BacklogTracer's user.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rbudzko/camel camel-2.15.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/508.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #508
----
commit f1ad2dbf7d720b08dc37917dfc104f1b7ba3df2e
Author: Robert Budźko <[email protected]>
Date: 2015-05-02T11:19:27Z
Issue CAMEL-8640. Encapsulated BacklogTracer queue. Implementation of queue
changed to list based instead of array based. Ensuring free space in queue
responsibility moved into BacklogTracer instead from BacklogTracer's user.
commit b2d599f7f4ea2c28841495291fa6d3ac150d8b5d
Author: Robert Budźko <[email protected]>
Date: 2015-05-02T11:33:06Z
Issue CAMEL-8640. Removed import * wildcards delivered in previous commit.
commit b84e72a233505aba2b9124bf33742d67e86d30a3
Author: Robert Budźko <[email protected]>
Date: 2015-05-02T11:37:31Z
Issue CAMEL-8640. Removed import * wildcards delivered in previous commit.
commit b81cfc988da9fb79f28316513f59e2f92400a914
Author: Robert Budźko <[email protected]>
Date: 2015-05-02T11:50:45Z
Issue CAMEL-8640. More safe ensuring of space in queue.
----
> BacklogTracer allocates 100k elements for an array even it is not enabled
> -------------------------------------------------------------------------
>
> Key: CAMEL-8640
> URL: https://issues.apache.org/jira/browse/CAMEL-8640
> Project: Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 2.15.1
> Reporter: Mateusz Nowakowski
> Fix For: 2.15.2, 2.16.0
>
>
> By default each camel context has one BacklogTracer which is by default
> disabled.
> However BacklogTracer contains a queue with
> {code}
> public static final int MAX_BACKLOG_SIZE = 100 * 1000;
> private final Queue<DefaultBacklogTracerEventMessage> queue = new
> ArrayBlockingQueue<DefaultBacklogTracerEventMessage>(MAX_BACKLOG_SIZE);
> {code}
> The easiest way:
> is it possible to replace it with LinkedBlockingQueue(int capacity)?
> Ideally the object could be initialized only when it is enabled but it seems
> BacklogTracer is not fully encapsulated (the queue reference is maintained
> also outside BacklogTracer in BacklogTracerAdvice)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
