[ 
https://issues.apache.org/jira/browse/CAMEL-8639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631670#comment-14631670
 ] 

Rob Sessink commented on CAMEL-8639:
------------------------------------

First steps in contributing to camel, so bear with me. See the attached patch 
and basic unit test that fixes this issue as described above. Regards Rob

 

> Camel FTP component cannot recover after network failure
> --------------------------------------------------------
>
>                 Key: CAMEL-8639
>                 URL: https://issues.apache.org/jira/browse/CAMEL-8639
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-ftp
>            Reporter: Marcin MarzyƄski
>
> Camel FTP endpoint cannot recover by itself after network failure if no 
> custom PollingConsumerPollStrategy is defined. Few years ago there was 
> similar issue (https://issues.apache.org/jira/browse/CAMEL-1838), and it was 
> fixed by adding in RemoteFileConsumer:
> this.setPollStrategy(new RemoteFilePollingConsumerPollStrategy());
> However it is broken again, as FtpEndpoint is overriding it with 
> DefaultPollingConsumerPollStrategy in initConsumerProperties method, 
> inherited from ScheduledPollEndpoint. I believe 
> RemoteFilePollingConsumerPollStrategy should be used as default in 
> RemoteFileEndpoint as well.
> Adding this.setPollStrategy(new RemoteFilePollingConsumerPollStrategy()); in 
> RemoteFilePollingConsumerPollStrategy should fix this issue.
> Workaround for this bug is to create RemoteFilePollingConsumerPollStrategy in 
> the registry and provide it directly to FTP endpoint by adding 
> consumer.pollStrategy=#myRemoteFilePollingConsumerPollStrategyBeanId to the 
> URL. This is also why FromFtpSimulateNetworkIssueRecoverTest didn't catch it 
> - it's using custom PollingStrategy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to