[
https://issues.apache.org/jira/browse/CAMEL-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043267#comment-15043267
]
ASF GitHub Bot commented on CAMEL-9391:
---------------------------------------
GitHub user pkletsko opened a pull request:
https://github.com/apache/camel/pull/710
[CAMEL-9391] Set parameter enableEventsResending should be before Atm…
…osphere wrap request
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pkletsko/camel CAMEL-9391
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/710.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #710
----
commit 2d77c3a338183492557effde353bb5d90015c42c
Author: Pavlo Kletsko <[email protected]>
Date: 2015-12-05T11:57:37Z
[CAMEL-9391] Set parameter enableEventsResending should be before
Atmosphere wrap request
----
> Set parameter enableEventsResending should be before Atmosphere wrap request
> ----------------------------------------------------------------------------
>
> Key: CAMEL-9391
> URL: https://issues.apache.org/jira/browse/CAMEL-9391
> Project: Camel
> Issue Type: Bug
> Components: camel-atmosphere-websocket
> Reporter: Pavlo Kletsko
> Labels: patch
> Fix For: 2.17.0
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This is a defect regarding CAMEL-9364 feature.
> WebsocketConsumer has service method where Atmosphere handle incoming
> request. In case value for enableEventsResending will be set after request is
> handled OnOpen event will not be sent at all.
> Consequently, set this value should be before such as :
> this.enableEventsResending = enableEventsResending;
> framework.doCometSupport(AtmosphereRequest.wrap(request),
> AtmosphereResponse.wrap(response));
> In addition to this because of CamelWebSocketServlet use init method for set
> enableEventsResending value, tests which were written for this feature are
> wrong. To solve this a new TestSupport class should be created where init
> parameter will be set correctly and tests depending on this parameter will be
> moved to separate class which extend the new TestSupport class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
