[ 
https://issues.apache.org/jira/browse/CAMEL-9954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15283816#comment-15283816
 ] 

Claus Ibsen commented on CAMEL-9954:
------------------------------------

Can we avoid the static registry as that does not go well in app servers and 
OSGi.

I think you need to add a way to register custom converters either on the model 
eg as an option on the bindy annotations. And possible also a way to configure 
on the bindy data format in the model, where you can then refer to custom 
converters in the registry by a name to the bean id.

> FormatFactory should be real Factory-pattern
> --------------------------------------------
>
>                 Key: CAMEL-9954
>                 URL: https://issues.apache.org/jira/browse/CAMEL-9954
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-bindy
>            Reporter: Arno Noordover
>            Priority: Minor
>         Attachments: 
> CAMEL_9954__FormatFactory_should_be_real_Factory_pattern.patch
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> The class org.apache.camel.dataformat.bindy.FormatFactory is a utility class 
> which supports a factory-pattern.
> According to the factory-pattern this should not be a utility-class but it 
> should be a class that can be instantiated.
> This class should implement an interface or extend an abstract class.
> Maybe we should make a factory per Format and choose amongst the following 
> solutions:
> * let each formatter answer the question about being able to format for 
> certain formating-options (based on type and optionally the pattern for all 
> "numeric" format factories);
> * put all formatters in a hashmap with the type as a key.
> With this last solution all the "numeric" format factory should decide which 
> format to return (e.g. BytePatternFormat or ByteFormat based on the pattern 
> being empty or not)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to