[
https://issues.apache.org/jira/browse/CAMEL-10038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15330624#comment-15330624
]
Matthew Zipay edited comment on CAMEL-10038 at 6/14/16 9:29 PM:
----------------------------------------------------------------
This appears to be the commit where the bug was introduced:
https://github.com/apache/camel/commit/07841d5be1175be1e9f383497588ff4e29e3008e
The thrown IllegalArgumentException was added in this commit, but I'm not sure
why - it fundamentally changes (breaks) the behavior but is not directly
relevant (as far as I can tell) to the stated fix in the commit message.
Is there some reason why Blueprint should explicitly *not* support falling back
to unaugmented properties when the placeholder property services do not find an
augmented key?
was (Author: mattz):
This appears to be the commit where the bug was introduced:
https://github.com/apache/camel/commit/07841d5be1175be1e9f383497588ff4e29e3008e
The thrown IllegalArgumentException was added in this commit, but I'm not sure
why - it fundamentally changes (breaks) the behavior but is not directly
relevant (as far as I can tell) to the stated fix in the commit message.
Is there some reason why Blueprint should explicitly *not* support falling back
to augmented properties when the placeholder property services do not find an
augmented key?
> BlueprintPropertiesParser breaks propertyPlaceholder
> fallbackToUnaugmentedProperty behavior
> -------------------------------------------------------------------------------------------
>
> Key: CAMEL-10038
> URL: https://issues.apache.org/jira/browse/CAMEL-10038
> Project: Camel
> Issue Type: Bug
> Components: camel-blueprint
> Affects Versions: 2.15.1
> Environment: Camel 2.15.1.redhat-620133
> JBoss Fuse 6.2.0.redhat-133
> openjdk version "1.8.0_45"
> OpenJDK Runtime Environment (build 1.8.0_45-b13)
> OpenJDK 64-Bit Server VM (build 25.45-b02, mixed mode)
> Linux 3.10.0-229.1.2.el7.x86_64 #1 SMP Fri Mar 6 17:12:08 EST 2015 x86_64
> GNU/Linux (RHEL 7)
> Reporter: Matthew Zipay
> Assignee: Grzegorz Grzybek
> Priority: Minor
> Labels: patch
> Attachments: camel-context.xml, example.bpp.fallback.cfg,
> fix_BlueprintPropertiesParser_fallbackToUnaugmentedProperty.patch
>
>
> When BlueprintPropertiesParser parses an "augmented" property key that is not
> found (i.e. value is null), it does not return the null value so that the
> fallbackToUnaugmentedProperty="true" (default) behavior can run. Instead, it
> immediately throws an IllegalArgumentException.
> As a result, it appears to be impossible to take advantage of
> fallbackToUnaugmentedProperty="true" behavior when using the Blueprint
> properties resolver/parser.
> I discovered this against Red Hat's JBoss Fuse impl of Camel, but am
> reporting it here because it appears to be a bug in base Camel. More details
> in comments.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
