[
https://issues.apache.org/jira/browse/CAMEL-10296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15471537#comment-15471537
]
ASF GitHub Bot commented on CAMEL-10296:
----------------------------------------
GitHub user gessnerfl opened a pull request:
https://github.com/apache/camel/pull/1161
CAMEL-10296: waitForConfirmsOrDie does not return if no timeout is set
for publisher acks and guaranteed delivery
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gessnerfl/camel
CAMEL-10296_waitForConfirmsOrDieWithoutTimeout
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/1161.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1161
----
commit 8827fab150f577106b4d7b682f0ceccd76525174
Author: Florian Gessner <[email protected]>
Date: 2016-09-07T19:04:10Z
CAMEL-10296: waitForConfirmsOrDie does not return if no timeout is set
for publisher acks and guaranteed delivery
----
> Guaranteed Delivery not working if no timeout is set
> ----------------------------------------------------
>
> Key: CAMEL-10296
> URL: https://issues.apache.org/jira/browse/CAMEL-10296
> Project: Camel
> Issue Type: Bug
> Components: camel-rabbitmq
> Affects Versions: 2.18.0
> Reporter: Florian Gessner
> Labels: github-pullrequest, integration-test
> Fix For: 2.18.0
>
>
> When guaranteed delivery is activated but no timeout is set for publisher
> acknowledgement waitForConfirmsOrDie will never return.
> This is because the close is not triggered on the channel even if the
> connection is closed when an exception is thrown in the return listener.
> This is also the reason why the integration test for the producer does not
> complete.
> The provided pull request fixes this issue in that way that it will just
> remember that a basic.return has been received and will throw the exception
> after waitForReturnOrDie completes
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)