[
https://issues.apache.org/jira/browse/CAMEL-10347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15525609#comment-15525609
]
ASF GitHub Bot commented on CAMEL-10347:
----------------------------------------
GitHub user yuruki opened a pull request:
https://github.com/apache/camel/pull/1188
CAMEL-10347: camel-scr todos and polish
https://issues.apache.org/jira/browse/CAMEL-10347
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yuruki/camel camel-scr-polish
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/1188.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1188
----
commit af63c0a9da77e1cd5fb79f94ec447566fa1e4ace
Author: Jyrki Ruuskanen <[email protected]>
Date: 2016-09-27T09:32:23Z
CAMEL-10347: camel-scr todos and polish
----
> Camel-scr todos and polish
> --------------------------
>
> Key: CAMEL-10347
> URL: https://issues.apache.org/jira/browse/CAMEL-10347
> Project: Camel
> Issue Type: Improvement
> Components: camel-scr
> Reporter: Jyrki Ruuskanen
> Priority: Minor
>
> Visibility / access:
> * Make context private. Use getter.
> * Get rid of registry member variable. Get registry through context when
> needed.
> * Make methods that are not supposed to be overriden final.
> Customization:
> * User can customize context's registry by overriding createRegistry()
> methods. Returns SimpleRegistry by default.
> * Remove hardcoded defaults from setupCamelContext().
> Corrections:
> * Do not explicitly create an OsgiServiceRegistry for
> OsgiDefaultCamelContext. The context will create one anyway and combine it
> with whatever createRegistry(BundleContext) returns in a CompositeRegistry.
> * Make camel-archetype-scr integration test run with Maven 3.3.9.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
