[
https://issues.apache.org/jira/browse/CAMEL-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15689884#comment-15689884
]
ASF GitHub Bot commented on CAMEL-10466:
----------------------------------------
GitHub user ecausarano opened a pull request:
https://github.com/apache/camel/pull/1298
CAMEL-10466 - fix/dropbox oom
See CAMEL-10466 - In a nutshell: I've changed the DropboxAPIFacade to use
an OutputStreamBuilder rather than a BAOS. All other changes are corollary to
this.
I'm still missing some questions about testing, returning empty content
etc... (see discussion in JIRA)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ecausarano/camel fix/dropbox-oom
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/1298.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1298
----
commit 21941ae950a5f0528f336ced860ebf23f5e99b28
Author: Edoardo Causarano <[email protected]>
Date: 2016-11-17T13:12:31Z
Refactor API Facade to avoid use of ByteArrays because it causes OOM.
Refactor DTO package members to be dumb DTOs.
commit 7bd0a7305fc0d0c70878e2dd464ec6898621780b
Author: Edoardo Causarano <[email protected]>
Date: 2016-11-17T13:31:01Z
Various tweaks and corrections suggested by IntelliJ
commit aaeaabf88deb11e25882c089ee8e4ed3a2fd7cca
Author: Edoardo Causarano <[email protected]>
Date: 2016-11-18T13:50:25Z
Fix obvious mistakes (how can I test all this without going insane?!)
----
> OOM in Dropbox component (uses ByteArrayOutputStream for get)
> -------------------------------------------------------------
>
> Key: CAMEL-10466
> URL: https://issues.apache.org/jira/browse/CAMEL-10466
> Project: Camel
> Issue Type: Bug
> Components: camel-dropbox
> Affects Versions: 2.18.0
> Reporter: Edoardo Causarano
> Labels: out-of-memory
> Fix For: 2.18.2, 2.19.0
>
>
> Using the Dropbox component to download files will consume large amounts of
> memory, often producing OOMs.
> This is due to the use of ByteArrayOutputStream objects in the implementation
> of org.apache.camel.component.dropbox.core.DropboxAPIFacade
> The component should use
> org.apache.camel.converter.stream.OutputStreamBuilder instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
