[
https://issues.apache.org/jira/browse/CAMEL-10086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15812945#comment-15812945
]
onder sezgin commented on CAMEL-10086:
--------------------------------------
$ grep -iR 'Pattern.compile' * | grep -v 'static final'
camel-core/src/main/java/org/apache/camel/builder/ExpressionBuilder.java:
final Pattern pattern = Pattern.compile(regexTokenizer);
camel-core/src/main/java/org/apache/camel/builder/ExpressionBuilder.java:
final Pattern pattern = Pattern.compile(regex);
camel-core/src/main/java/org/apache/camel/builder/ExpressionBuilder.java:
final Pattern pattern = Pattern.compile(regex);
camel-core/src/main/java/org/apache/camel/builder/PredicateBuilder.java:
return regex(expression, Pattern.compile(regex));
camel-core/src/main/java/org/apache/camel/component/file/GenericFileEndpoint.java:
this.includePattern = Pattern.compile(include,
Pattern.CASE_INSENSITIVE);
camel-core/src/main/java/org/apache/camel/component/file/GenericFileEndpoint.java:
this.excludePattern = Pattern.compile(exclude,
Pattern.CASE_INSENSITIVE);
camel-core/src/main/java/org/apache/camel/impl/DefaultHeaderFilterStrategy.java:
outFilterPattern = Pattern.compile(value);
camel-core/src/main/java/org/apache/camel/impl/DefaultHeaderFilterStrategy.java:
inFilterPattern = Pattern.compile(value);
camel-core/src/main/java/org/apache/camel/support/TokenXMLExpressionIterator.java:
Pattern.compile(MessageFormat.format(SCAN_BLOCK_TOKEN_REGEX_TEMPLATE,
camel-core/src/main/java/org/apache/camel/support/TokenXMLExpressionIterator.java:
Pattern.compile(MessageFormat.format(SCAN_PARENT_TOKEN_REGEX_TEMPLATE,
camel-core/src/main/java/org/apache/camel/support/TokenXMLPairExpressionIterator.java:
this.startTokenPattern = Pattern.compile(tokenSb.toString());
camel-core/src/main/java/org/apache/camel/support/TokenXMLPairExpressionIterator.java:
this.inheritNamespaceTokenPattern =
Pattern.compile(tokenSb.toString(), Pattern.MULTILINE | Pattern.DOTALL);
camel-core/src/main/java/org/apache/camel/support/XMLTokenExpressionIterator.java:
lcpattern = Pattern.compile(sb.toString());
camel-core/src/main/java/org/apache/camel/util/component/ApiMethodHelper.java:
aliasPatterns.put(Pattern.compile(alias.getKey()), alias.getValue());
camel-core/src/main/java/org/apache/camel/util/component/ArgumentSubstitutionParser.java:
nameReplacement.typePattern =
Pattern.compile(substitution.argType);
camel-core/src/main/java/org/apache/camel/util/component/ArgumentSubstitutionParser.java:
argMap.put(Pattern.compile(arg.getKey()), arg.getValue());
camel-core/src/main/java/org/apache/camel/util/component/ArgumentSubstitutionParser.java:
methodMap.put(Pattern.compile(method.getKey()), argMap);
camel-core/src/main/java/org/apache/camel/util/jsse/FilterParameters.java:
patterns.add(Pattern.compile(this.parsePropertyValue(expression)));
camel-core/src/test/java/org/apache/camel/util/jsse/SSLContextParametersTest.java:
Arrays.asList(new
Pattern[]{Pattern.compile("TLS.*")}),
camel-core/src/test/java/org/apache/camel/util/jsse/SSLContextParametersTest.java:
Arrays.asList(new Pattern[]{Pattern.compile(".*")}),
camel-core/src/test/java/org/apache/camel/util/jsse/SSLContextParametersTest.java:
Arrays.asList(new
Pattern[]{Pattern.compile("SSL.*")}));
components/camel-aws/src/test/java/org/apache/camel/component/aws/ddbstream/DdbStreamConsumerTest.java:
private final Pattern shardIteratorPattern =
Pattern.compile("shard_iterator_d_0*(\\d+)");
components/camel-mail/src/main/java/org/apache/camel/dataformat/mime/multipart/MimeMultipartDataFormat.java:
this.includeHeaders = Pattern.compile(includeHeaders,
Pattern.CASE_INSENSITIVE);
components/camel-salesforce/camel-salesforce-component/src/test/java/org/apache/camel/component/salesforce/api/dto/composite/SObjectBatchTest.java:
final String json =
Pattern.compile("\\s+(?=([^\"]*\"[^\"]*\")*[^\"]*$)", Pattern.DOTALL)
components/camel-salesforce/camel-salesforce-maven-plugin/src/main/java/org/apache/camel/maven/CamelSalesforceMojo.java:
incPattern = Pattern.compile(includePattern.trim());
components/camel-salesforce/camel-salesforce-maven-plugin/src/main/java/org/apache/camel/maven/CamelSalesforceMojo.java:
excPattern = Pattern.compile(excludePattern.trim());
components/camel-snakeyaml/src/main/java/org/apache/camel/component/snakeyaml/TypeFilters.java:
this.predicates =
Collections.singletonList(Pattern.compile(pattern).asPredicate());
components/camel-sql/src/main/java/org/apache/camel/component/sql/DefaultSqlPrepareStatementStrategy.java:
Matcher paramMatcher = Pattern.compile("\\:\\?in\\:" +
foundEscaped, Pattern.MULTILINE).matcher(query);
components/camel-yammer/src/main/java/org/apache/camel/component/yammer/scribe/JsonTokenExtractor.java:
accessTokenPattern = Pattern.compile(tokenRegex);
platforms/commands/commands-core/src/main/java/org/apache/camel/commands/internal/RegexUtil.java:
* @return regex string that could be fed to Pattern.compile
tests/camel-itest-spring-boot/src/main/java/org/apache/camel/itest/springboot/command/UnitTestCommand.java:
Pattern pattern = Pattern.compile(config.getUnitTestInclusionPattern());
tests/camel-itest-spring-boot/src/main/java/org/apache/camel/itest/springboot/command/UnitTestCommand.java:
Pattern exclusionPattern =
Pattern.compile(config.getUnitTestExclusionPattern());
tests/camel-itest-spring-boot/src/test/java/org/apache/camel/itest/springboot/util/ArquillianPackager.java:
Pattern pattern = Pattern.compile(regex);
tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/AbstractApiMethodGeneratorMojo.java:
propertyNamePattern = Pattern.compile(excludeConfigNames);
tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/AbstractApiMethodGeneratorMojo.java:
propertyTypePattern = Pattern.compile(excludeConfigTypes);
tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/JavadocApiMethodGeneratorMojo.java:
final Pattern packagePatterns = Pattern.compile(excludePackages);
tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/JavadocApiMethodGeneratorMojo.java:
final Pattern classPatterns = (excludeClasses != null) ?
Pattern.compile(excludeClasses) : null;
tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/JavadocApiMethodGeneratorMojo.java:
final Pattern includeMethodPatterns = (includeMethods != null) ?
Pattern.compile(includeMethods) : null;
tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/JavadocApiMethodGeneratorMojo.java:
final Pattern excludeMethodPatterns = (excludeMethods != null) ?
Pattern.compile(excludeMethods) : null;
> Remove Pattern.compile usages
> -----------------------------
>
> Key: CAMEL-10086
> URL: https://issues.apache.org/jira/browse/CAMEL-10086
> Project: Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Mateusz Nowakowski
> Priority: Minor
> Fix For: Future
>
>
> Please heck Pattern.compile usage across Camel source code - also *not*
> direct usage.
> For example:
> Whenever one of these methods are used from String class a Pattern.compile()
> is utilized:
> - matches
> - replaceFirst
> - replaceAll
> - replace
> - split: has an optimization and for certain characters it doesn’t use
> Pattern.compile.
> For example:
> GenericFileConsumer.isMatched calls name.matches(endpoint.getExclude())
> GenericFileEndpoint could contain also excludePattern as well.
> Possible solution:
> Walk through the code and replace usages of these methods with static Pattern
> variables.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
