[ 
https://issues.apache.org/jira/browse/CAMEL-10740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837766#comment-15837766
 ] 

ASF GitHub Bot commented on CAMEL-10740:
----------------------------------------

GitHub user bobpaulin opened a pull request:

    https://github.com/apache/camel/pull/1422

    CAMEL-10740 - Initial work for camel-tika component.

    Hi,
    
    A couple of notes about the PR.  
    
    1) Under platforms I've included the Karaf feature but I did not include 
the code generated for the spring boot starter since I haven't done any testing 
within Boot.  
    
    2) I have prefixed the Metadata headers generated by Tika with "Tika".  I 
hadn't seen this done in other projects but with the shear number of them I 
thought it might be useful to have some sort of namespace to prevent 
collisions.  Like anything else in this PR I'm open to changing it if that is 
considered bad practice.
    
    3) The test document and image included are from the Tika test resources.  
So my expectation is that they are licensed appropriately.  
    
    Thanks for having such a well documented contribution process.  I found it 
very helpful.
    
    - Bob

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bobpaulin/camel feature/camel-tika-component

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/1422.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1422
    
----
commit 8f0eb0b033bfdb8d4a7cbd62badc4b240ed3029d
Author: Bob Paulin <[email protected]>
Date:   2017-01-24T23:42:10Z

    CAMEL-10740 - Initial work for camel-tika component.

----


> Add Tika Component
> ------------------
>
>                 Key: CAMEL-10740
>                 URL: https://issues.apache.org/jira/browse/CAMEL-10740
>             Project: Camel
>          Issue Type: New Feature
>    Affects Versions: 2.19.0
>            Reporter: Bob Paulin
>            Priority: Minor
>
> Add Tika Component to Apache Camel.  See 
> https://lists.apache.org/thread.html/6cb060e216eeb6e33bffed38488e73490bec546b362450f787391f0c@%3Cdev.camel.apache.org%3E



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to