[jira] [Commented] (CAMEL-10842) Component JSon schema - JSon values should not always be string types

[Claus Ibsen (JIRA)]

    [ 
https://issues.apache.org/jira/browse/CAMEL-10842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869541#comment-15869541
 ] 

Claus Ibsen commented on CAMEL-10842:
-------------------------------------

For example before
{code}
{
 "component": {
    "kind": "component",
    "scheme": "salesforce",
    "syntax": "salesforce:operationName:topicName",
    "title": "Salesforce",
    "description": "The salesforce component is used for integrating Camel with 
the massive Salesforce API.",
    "label": "api,cloud,crm",
    "deprecated": "false",
    "async": "false",
    "javaType": "org.apache.camel.component.salesforce.SalesforceComponent",
    "firstVersion": "2.12.0",
    "groupId": "org.apache.camel",
    "artifactId": "camel-salesforce",
    "version": "2.19.0-SNAPSHOT"
  },
  "componentProperties": {
    "loginConfig": { "kind": "property", "group": "security", "label": 
"security", "required": "false", "type": "object", "javaType": 
"org.apache.camel.component.salesforce.SalesforceLoginConfig", "deprecated": 
"false", "secret": "false", "description": "To use the shared 
SalesforceLoginConfig as login configuration" },
    "loginUrl": { "kind": "property", "group": "security", "label": "security", 
"required": "false", "type": "string", "javaType": "java.lang.String", 
"deprecated": "false", "secret": "false", "defaultValue": 
"https://login.salesforce.com";, "description": "Salesforce login URL defaults 
to https://login.salesforce.com"; },
    "clientId": { "kind": "property", "group": "security", "label": "security", 
"required": "false", "type": "string", "javaType": "java.lang.String", 
"deprecated": "false", "secret": "true", "description": "Salesforce connected 
application Consumer Key" },
    "clientSecret": { "kind": "property", "group": "security", "label": 
"security", "required": "false", "type": "string", "javaType": 
"java.lang.String", "deprecated": "false", "secret": "true", "description": 
"Salesforce connected application Consumer Secret" },
{code}

And after
{code}
{
 "component": {
    "kind": "component",
    "scheme": "salesforce",
    "syntax": "salesforce:operationName:topicName",
    "title": "Salesforce",
    "description": "The salesforce component is used for integrating Camel with 
the massive Salesforce API.",
    "label": "api,cloud,crm",
    "deprecated": false,
    "async": false,
    "javaType": "org.apache.camel.component.salesforce.SalesforceComponent",
    "firstVersion": "2.12.0",
    "groupId": "org.apache.camel",
    "artifactId": "camel-salesforce",
    "version": "2.19.0-SNAPSHOT"
  },
  "componentProperties": {
    "loginConfig": { "kind": "property", "group": "security", "label": 
"security", "required": false, "type": "object", "javaType": 
"org.apache.camel.component.salesforce.SalesforceLoginConfig", "deprecated": 
false, "secret": false, "description": "To use the shared SalesforceLoginConfig 
as login configuration" },
    "loginUrl": { "kind": "property", "group": "security", "label": "security", 
"required": false, "type": "string", "javaType": "java.lang.String", 
"deprecated": false, "secret": false, "defaultValue": 
"https://login.salesforce.com";, "description": "Salesforce login URL defaults 
to https://login.salesforce.com"; },
    "clientId": { "kind": "property", "group": "security", "label": "security", 
"required": false, "type": "string", "javaType": "java.lang.String", 
"deprecated": false, "secret": true, "description": "Salesforce connected 
application Consumer Key" },
    "clientSecret": { "kind": "property", "group": "security", "label": 
"security", "required": false, "type": "string", "javaType": 
"java.lang.String", "deprecated": false, "secret": true, "description": 
"Salesforce connected application Consumer Secret" },
{code}

> Component JSon schema - JSon values should not always be string types
> ---------------------------------------------------------------------
>
>                 Key: CAMEL-10842
>                 URL: https://issues.apache.org/jira/browse/CAMEL-10842
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-catalog, tooling
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>             Fix For: 2.19.0
>
>
> Lets take a look at generating the json output using boolean, numeric values 
> when they are. So we dont have
> "secret": "false"
> but have
> "secret": false



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)