[
https://issues.apache.org/jira/browse/CAMEL-10840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871305#comment-15871305
]
ASF GitHub Bot commented on CAMEL-10840:
----------------------------------------
GitHub user ribeaud opened a pull request:
https://github.com/apache/camel/pull/1471
[CAMEL-10840] CsvDataFormat.setRecordConverterRef not usable
Sorry, something went wrong with line breaks (**GitHub** is thinking that
the whole file `CsvRecordConverter.java` has changed). The only relevant change
is the *public* keyword added to the interface.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ribeaud/camel feature/CAMEL-10840
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/1471.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1471
----
commit 6b407cf4d22d259ae27bc52ec44f08523aec4564
Author: Christian Ribeaud <christ...@ribeaud.ch>
Date: 2017-02-17T06:40:18Z
[CAMEL-10840] Make 'CsvRecordConverter' public and visible
Tests included.
commit 54546403a1fdd9f91f62eb5d2c83463ffe79528c
Author: Christian Ribeaud <christ...@ribeaud.ch>
Date: 2017-02-17T06:57:32Z
[CAMEL-10840] Fix checkstyle errors
----
> CsvDataFormat.setRecordConverterRef not usable
> ----------------------------------------------
>
> Key: CAMEL-10840
> URL: https://issues.apache.org/jira/browse/CAMEL-10840
> Project: Camel
> Issue Type: Improvement
> Components: camel-csv
> Affects Versions: 2.18.1
> Reporter: Christian Ribeaud
> Priority: Minor
> Fix For: 2.18.3, 2.19.0
>
>
> Following interface {{org.apache.camel.dataformat.csv.CsvRecordConverter}} is
> *package* protected. This is actually fine because it is used internally.
> There are two implementations in {{CsvRecordConverters}}. However
> {{org.apache.camel.model.dataformat.CsvDataFormat}} contains following
> *public* methods:
> {code:java}
> public String getRecordConverterRef() {
> return recordConverterRef;
> }
> /**
> * Refers to a custom <tt>CsvRecordConverter</tt> to lookup from the registry
> to use.
> */
> public void setRecordConverterRef(String recordConverterRef) {
> this.recordConverterRef = recordConverterRef;
> }
> {code}
> So, it seems possible to specify my own {{CsvRecordConverter}} but, because
> of the point mentioned earlier, this is actually NOT (easily) possible.
> I came across this point because I was looking for a mechanism allowing me to
> proxy the values being taken from {{CSVRecord}} to *Map* or *List*.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
