[ 
https://issues.apache.org/jira/browse/CAMEL-10650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15961175#comment-15961175
 ] 

ASF GitHub Bot commented on CAMEL-10650:
----------------------------------------

GitHub user nicolaferraro opened a pull request:

    https://github.com/apache/camel/pull/1607

    CAMEL-10650: global sslContextParameters

    Submitting for a review.
    It basically adds global ssl parameters that can be configured using 
spring-boot properties. There is no ide autocompletion at the moment, bu I'll 
add it. A sample configuration is contained in the tests e.g. of 
`camel-undertow-starter`.
    
    To create a global ssl config, I needed to take care of:
    - Change each component using SSLContextParameters to lookup the new 
default if no configuration is given
    - Not clash with spring xml configuration of SSLContextParameters, so I 
avoided putting into the registry an instance of SSLContextParameters, instead 
I put a GlobalSSLContextParametersSupplier class.
    - Make sure that taking a default does not change the behaviour of the 
component: for components where the presence of a SSLContextParameters in the 
config turns on the SSL mode, I've put a flag named 
"useGlobalSslContextParameters" to disable the feature. For some components, 
the default is false (do not use the global config).
    
    For http/tcp components there is no need of such flag since SSL is enabled 
by other means (e.g. "https://"; in the uri). Some components have their own 
flag to enable SSL.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nicolaferraro/camel master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/1607.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1607
    
----
commit 854774eca5c8caec34fc41bb8d52386ecd581537
Author: Nicola Ferraro <[email protected]>
Date:   2017-04-06T12:52:06Z

    CAMEL-10650: adding sslContextParameters to spring-boot configuration

----


> camel-spring-boot - Allow to configure SSLContextParameters in auto 
> configuration
> ---------------------------------------------------------------------------------
>
>                 Key: CAMEL-10650
>                 URL: https://issues.apache.org/jira/browse/CAMEL-10650
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-spring-boot
>            Reporter: Claus Ibsen
>            Assignee: Nicola Ferraro
>             Fix For: 2.19.0
>
>
> Camel has org.apache.camel.util.jsse.SSLContextParameters from
> http://camel.apache.org/camel-configuration-utilities.html
> We should allow to configure this from spring boot auto configuration so 
> people can easier setup this in the application properties file etc.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to