[
https://issues.apache.org/jira/browse/CAMEL-11348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16032541#comment-16032541
]
Claus Ibsen commented on CAMEL-11348:
-------------------------------------
Yeah that is okay, but we can also leverage that if matchOnUriPrefix=true we
dont need to do equals check
if matchOnUriPrefix
// just check that its starts with the same
else
// do that ignore equals check
> Small Performance optimization in RestConsumerContextPathMatcher
> ----------------------------------------------------------------
>
> Key: CAMEL-11348
> URL: https://issues.apache.org/jira/browse/CAMEL-11348
> Project: Camel
> Issue Type: Improvement
> Components: camel-core, rest
> Affects Versions: 2.19.0
> Reporter: Zoltan Farkas
> Assignee: Andrea Cosentino
> Priority: Minor
> Fix For: 2.20.0
>
>
> at
> https://github.com/apache/camel/blob/57711e2696c32ef3ab99ad4ccc62f09bfda2ab40/camel-core/src/main/java/org/apache/camel/support/RestConsumerContextPathMatcher.java#L97
> :
> {code}
> String p1 = requestPath.toLowerCase(Locale.ENGLISH);
> String p2 = consumerPath.toLowerCase(Locale.ENGLISH);
> if (p1.equals(p2)) {
> return true;
> }
> if (matchOnUriPrefix && p1.startsWith(p2)) {
> return true;
> }
> return false;
> {code}
> we can improve to:
> {code}
> if (requestPath.equalsIgnoreCase(consumerPath)) {
> return true;
> }
> return matchOnUriPrefix && requestPath.regionMatches(true, 0,
> consumerPath, 0, consumerPath.length());
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
