[
https://issues.apache.org/jira/browse/CAMEL-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059039#comment-16059039
]
ASF GitHub Bot commented on CAMEL-11244:
----------------------------------------
Github user tlehoux closed the pull request at:
https://github.com/apache/camel/pull/1770
> camel-hazelcast: use string/enum instead of numeric operation type
> ------------------------------------------------------------------
>
> Key: CAMEL-11244
> URL: https://issues.apache.org/jira/browse/CAMEL-11244
> Project: Camel
> Issue Type: Improvement
> Components: camel-hazelcast
> Reporter: Luca Burgazzoli
> Fix For: 2.20.0
>
>
> camel-hazelcast defines the operation using an integer but you can also use a
> string when configuring the endpoint so it is a mix of styles that we should
> avoid so it would be nice if we use enum/string everywhere.
> {code:java}
> HazelcastOperation {
> PUT,
> ...;
> }
> HazelcastDefaultEndpoint {
> @UriParam
> private HazelcastOperation defaultOperation;
> }
> {code}
> This difference of types adds some additional maintenance work as one has to
> maintain:
> -
> [maping|https://github.com/apache/camel/blob/master/components/camel-hazelcast/src/main/java/org/apache/camel/component/hazelcast/HazelcastComponentHelper.java#L27]
> -
> [constants|https://github.com/apache/camel/blob/master/components/camel-hazelcast/src/main/java/org/apache/camel/component/hazelcast/HazelcastConstants.java#L60-L104]
> - [operation
> enums|https://github.com/apache/camel/blob/master/components/camel-hazelcast/src/main/java/org/apache/camel/component/hazelcast/HazelcastDefaultEndpoint.java#L44-L46]
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
