[ 
https://issues.apache.org/jira/browse/CAMEL-11446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079639#comment-16079639
 ] 

ASF GitHub Bot commented on CAMEL-11446:
----------------------------------------

GitHub user PascalSchumacher opened a pull request:

    https://github.com/apache/camel/pull/1811

    CAMEL-11446: Use awaitility in camel-core for testing where we otherw…

    …ise use thread sleep which can be speeded up.
    
    Use #untilAsserted instead of #until where possible to reduce code 
duplication.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/PascalSchumacher/camel 
untilAsserted_instead_of_until

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/1811.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1811
    
----
commit 1da5d65979b4510439aef045a28134f111d677ed
Author: Pascal Schumacher <[email protected]>
Date:   2017-07-09T15:22:46Z

    CAMEL-11446: Use awaitility in camel-core for testing where we otherwise 
use thread sleep which can be speeded up.
    
    Use #untilAsserted instead of #until where possible to reduce code 
duplication.

----


> Look at using awaitility in camel-core tests when we wait via thread sleep etc
> ------------------------------------------------------------------------------
>
>                 Key: CAMEL-11446
>                 URL: https://issues.apache.org/jira/browse/CAMEL-11446
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core, tests
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>             Fix For: Future
>
>
> We can speedup some of the tests in camel-core by using
> https://github.com/awaitility/awaitility
> To wait for the condition before continuing. 
> We can also use NotifyBuilder which we do in some tests like, when there is 
> only 1 message to wait for
> oneExchangeDone.matchesMockWaitTime();



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to