[ 
https://issues.apache.org/jira/browse/CAMEL-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096180#comment-16096180
 ] 

Radek Mensik commented on CAMEL-11553:
--------------------------------------

Sure, but deprecated classes: com.github.kristofa.brave.Brave is deprecated and 
should be used _brave.Tracing_ and there is few more...


> Upgrade to Brave 4
> ------------------
>
>                 Key: CAMEL-11553
>                 URL: https://issues.apache.org/jira/browse/CAMEL-11553
>             Project: Camel
>          Issue Type: Task
>          Components: camel-zipkin
>    Affects Versions: 2.19.1
>            Reporter: Radek Mensik
>            Assignee: Kevin Earls
>            Priority: Minor
>
> It would be nice to have up to date library not using deprecated code, 
> because:
> Brave v. 4 allows you to use _brave.Tracing_ so one can easily register 
> https://github.com/openzipkin/brave/tree/master/context/slf4j which allows 
> you to have in each log line info about spans:
> {code:java}
> 2017-07-17 17:44:08.526  INFO [proxy,b805c5edbe362a7c,b805c5edbe362a7c,true]
> {code}
> Then it is easy to copy and use span id to zipkin UI in case of debugging. 
> (btw currently there is Long value of span instead of Hexadecimal printed).
> There is possibility to overlap with version 3 and 4 -> 
> https://github.com/openzipkin/brave/tree/master/brave#upgrading-from-brave-3 
> so this could be good start.
> Also _brave.sampler.Sampler_ should be used in stead of 
> _com.github.kristofa.brave.Sampler_



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to