[ 
https://issues.apache.org/jira/browse/CAMEL-11756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16161635#comment-16161635
 ] 

Claus Ibsen commented on CAMEL-11756:
-------------------------------------

Apache Camel does not use commons-logging, we use slf4j-api as the logging 
facade.

However some 3rd party frameworks use commons-logging.

For example just now I am building and doing some tests with all the 
camel-starter component (eg for spring boot) with Spring Boot 2.
And it may be that Hystrix library uses commons-logging somewhere, as the unit 
test fails with

{code}
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running 
org.apache.camel.component.hystrix.processor.HystrixHierarchicalConfigurationTest
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 3.011 sec <<< 
FAILURE! - in 
org.apache.camel.component.hystrix.processor.HystrixHierarchicalConfigurationTest
testConfiguration(org.apache.camel.component.hystrix.processor.HystrixHierarchicalConfigurationTest)
  Time elapsed: 0.004 sec  <<< ERROR!
java.lang.IllegalStateException: Failed to load ApplicationContext
Caused by: org.springframework.beans.factory.BeanCreationException: Error 
creating bean with name 'servletRegistrationBean' defined in class path 
resource 
[org/apache/camel/component/hystrix/springboot/HystrixMappingAutoConfiguration.class]:
 Bean instantiation via factory method failed; nested exception is 
org.springframework.beans.BeanInstantiationException: Failed to instantiate 
[org.springframework.boot.web.servlet.ServletRegistrationBean]: Factory method 
'servletRegistrationBean' threw exception; nested exception is 
java.lang.NoClassDefFoundError: org/apache/commons/logging/impl/NoOpLog
Caused by: org.springframework.beans.BeanInstantiationException: Failed to 
instantiate [org.springframework.boot.web.servlet.ServletRegistrationBean]: 
Factory method 'servletRegistrationBean' threw exception; nested exception is 
java.lang.NoClassDefFoundError: org/apache/commons/logging/impl/NoOpLog
Caused by: java.lang.NoClassDefFoundError: 
org/apache/commons/logging/impl/NoOpLog
Caused by: java.lang.ClassNotFoundException: 
org.apache.commons.logging.impl.NoOpLog
{code}

But when I add commons-logging as test scope the test passes
{code}
    <dependency>
      <groupId>commons-logging</groupId>
      <artifactId>commons-logging</artifactId>
      <scope>test</scope>
    </dependency>
{code}

> camel-spring-boot2 - Create experimental spring boot 2 component
> ----------------------------------------------------------------
>
>                 Key: CAMEL-11756
>                 URL: https://issues.apache.org/jira/browse/CAMEL-11756
>             Project: Camel
>          Issue Type: Task
>          Components: camel-spring-boot
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>             Fix For: 2.20.0
>
>
> We should try get started with the migration effort for getting Camel running 
> on Spring Boot 2.0.x.
> There may be issues with the starter component as Spring Boot guys changed 
> stuff how auto configuration and setting properties works. So we may need to 
> have some kind of interface in camel-spring-boot and camel-spring-boot2 where 
> we can have different implementation that the -starter can use.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to