[ 
https://issues.apache.org/jira/browse/CAMEL-11871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189697#comment-16189697
 ] 

Peter Palaga commented on CAMEL-11871:
--------------------------------------

bq. proposed change breaks unit tests written against ActiveMQ 5.x

In b81e09d [1] I checked that the stomp unit tests can be fixed to work with 
the proposed fix.

Backwards compatibility is a valid concern as long as the old behavior can be 
called correct. The old behavior is rather incorrect because it does not 
properly cover the whole range of the applicability of the stomp protocol. 
Keeping the incorrect behavior a default and making the correct behavior 
optional is doable but sounds strange.

[1] 
https://github.com/apache/camel/pull/1989/commits/b81e09da51eff29d4b17a392a9d4a4ca564d6d88

> Stomp component should not modify the destination name
> ------------------------------------------------------
>
>                 Key: CAMEL-11871
>                 URL: https://issues.apache.org/jira/browse/CAMEL-11871
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-stomp
>            Reporter: Peter Palaga
>            Assignee: Peter Palaga
>             Fix For: 2.20.0
>
>
> Stomp Camel Component modifies the destination name passed via endpoint URI 
> by prepending a slash to it and by replacing ':' with '/' [1]. This turns out 
> to be problematic when targeting an ActiveMQ Artemis instance embedded in 
> WildFly. For whatever reason, it expects queue names to start with 
> "jms.queue." without the initial slash.
> There is a WildFly Camel integration test demonstrating the issue: [2]
> StompComponent should not assume anything about the naming scheme, because it 
> has no control over the decisions made on the broker side.
> [1] 
> https://github.com/apache/camel/blob/98b3d7eae9959645c4bc023bf4896d036ce75642/components/camel-stomp/src/main/java/org/apache/camel/component/stomp/StompComponent.java#L57
> [2] 
> https://github.com/ppalaga/wildfly-camel/commit/15e3e6098b3976cb057f4208565296ea6bd54017#diff-bf122ce705f9ef0b3920d968d1f13f2a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to