[ 
https://issues.apache.org/jira/browse/CAMEL-12017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259076#comment-16259076
 ] 

ASF GitHub Bot commented on CAMEL-12017:
----------------------------------------

oscerd closed pull request #2102: CAMEL-12017: Added httpclient dependency
URL: https://github.com/apache/camel/pull/2102
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/components/camel-google-bigquery/pom.xml 
b/components/camel-google-bigquery/pom.xml
index ce9a1746dfc..812fea01b08 100644
--- a/components/camel-google-bigquery/pom.xml
+++ b/components/camel-google-bigquery/pom.xml
@@ -39,12 +39,14 @@
   </properties>
 
   <dependencies>
-
     <dependency>
       <groupId>org.apache.camel</groupId>
       <artifactId>camel-core</artifactId>
     </dependency>
-
+    <dependency>
+      <groupId>org.apache.httpcomponents</groupId>
+      <artifactId>httpclient</artifactId>
+    </dependency>
     <dependency>
       <groupId>com.google.apis</groupId>
       <artifactId>google-api-services-bigquery</artifactId>
diff --git a/components/camel-google-pubsub/pom.xml 
b/components/camel-google-pubsub/pom.xml
index 5ec43908711..69092777c73 100644
--- a/components/camel-google-pubsub/pom.xml
+++ b/components/camel-google-pubsub/pom.xml
@@ -48,6 +48,10 @@
             <groupId>org.apache.camel</groupId>
             <artifactId>camel-core</artifactId>
         </dependency>
+        <dependency>
+          <groupId>org.apache.httpcomponents</groupId>
+          <artifactId>httpclient</artifactId>
+        </dependency>
         <dependency>
             <groupId>com.google.apis</groupId>
             <artifactId>google-api-services-pubsub</artifactId>


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Google PubSub and BigQuery components miss dependency declarations
> ------------------------------------------------------------------
>
>                 Key: CAMEL-12017
>                 URL: https://issues.apache.org/jira/browse/CAMEL-12017
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-google-pubsub
>    Affects Versions: 2.20.1
>            Reporter: Evgeny Minkevich
>            Priority: Minor
>             Fix For: 2.21.0
>
>
> Google PubSub and Google Bigquery components require Apache HTTP client, 
> which is NOT explicitly called out in dependencies.
> As such they would work, if camel-http4 component is mentioned in the 
> dependencies, but would fail on their own.
> As a developer I would like to be able to define an absolute minimum of the 
> dependencies, thus I need the component to import all components they rely 
> on, themselves.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to